slic3r-prusa3d: 1.40.1 -> 1.41.0 #44077

Moredread · 2018-07-25T04:31:53Z

Motivation for this change

~~1.41.0 isn't out yet, but I want to document what needs to be updated for the final release.~~

The latest alpha needs a few more dependencies. Also NLOPT needs to be set manually, as the package isn't found otherwise. :/

gtest is needed although it seems unittests aren't even build by default. Might be worth it to report that to upstream.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Moredread · 2018-08-31T10:09:25Z

1.41.0 has been tagged upstream, just waiting till they release it officially.

edit it was released

Moredread · 2018-09-04T17:21:49Z

@tweber Can you have look please?

matthewbauer · 2018-09-30T17:56:51Z

@GrahamcOfBorg build slic3r-prusa3d

GrahamcOfBorg · 2018-09-30T17:57:05Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slic3r-prusa3d

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-30T18:00:34Z

Failure on aarch64-linux (full log)

Attempted: slic3r-prusa3d

Partial log (click to expand)

/build/source/xs/src/libslic3r/PlaceholderParser.cpp:1000:72:   required from 'Slic3r::client::macro_processor<Iterator>::macro_processor() [with Iterator = __gnu_cxx::__normal_iterator<const char*, std::__cxx11::basic_string<char> >]'
/build/source/xs/src/libslic3r/PlaceholderParser.cpp:1180:33:   required from here
/build/source/xs/src/libslic3r/PlaceholderParser.cpp:462:32: warning: unused variable 'mask' [-Wunused-variable]
             const std::string *mask     = nullptr;
                                ^~~~
[ 95%] Linking CXX static library liblibslic3r.a
[ 95%] Built target libslic3r
make: *** [Makefile:141: all] Error 2
builder for '/nix/store/9f338pkpvwvjn0n3xpjixlsc2hh4adcd-slic3r-prusa-edition-1.41.0.drv' failed with exit code 2
error: build of '/nix/store/9f338pkpvwvjn0n3xpjixlsc2hh4adcd-slic3r-prusa-edition-1.41.0.drv' failed

GrahamcOfBorg · 2018-09-30T18:46:28Z

Success on x86_64-linux (full log)

Attempted: slic3r-prusa3d

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0
shrinking /nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0/lib/slic3r-prusa3d/auto/Slic3r/XS/XS.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0/lib  /nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0/bin
patching script interpreter paths in /nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0
/nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0/bin/.slic3r-prusa3d-wrapped: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/kdbzhdzm43r58smfx29x3233dagihxp5-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0...
/nix/store/n6p32swhj3p9ds0rn9n0i8zd7wbsc013-slic3r-prusa-edition-1.41.0

timokau · 2018-10-01T19:44:35Z

pkgs/applications/misc/slic3r/prusa3d.nix

    eigen
    glew
+    gtest
+    makeWrapper


This should be in nativeBuildInputs since it is only used at build time, never at runtime.

I have moved them, as well as cmake. I'm not sure though if this is the cause for failing on aarch64.

pkgs/applications/misc/slic3r/prusa3d.nix

timokau · 2018-10-02T22:13:33Z

@GrahamcOfBorg build slic3r-prusa3d

GrahamcOfBorg · 2018-10-02T22:13:43Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slic3r-prusa3d

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T22:17:09Z

Failure on aarch64-linux (full log)

Attempted: slic3r-prusa3d

Partial log (click to expand)

/build/source/xs/src/libslic3r/PlaceholderParser.cpp:1000:72:   required from 'Slic3r::client::macro_processor<Iterator>::macro_processor() [with Iterator = __gnu_cxx::__normal_iterator<const char*, std::__cxx11::basic_string<char> >]'
/build/source/xs/src/libslic3r/PlaceholderParser.cpp:1180:33:   required from here
/build/source/xs/src/libslic3r/PlaceholderParser.cpp:462:32: warning: unused variable 'mask' [-Wunused-variable]
             const std::string *mask     = nullptr;
                                ^~~~
[ 95%] Linking CXX static library liblibslic3r.a
[ 95%] Built target libslic3r
make: *** [Makefile:141: all] Error 2
builder for '/nix/store/z0my0l3v811ivgjsi7l589szcmg1yvbv-slic3r-prusa-edition-1.41.0.drv' failed with exit code 2
error: build of '/nix/store/z0my0l3v811ivgjsi7l589szcmg1yvbv-slic3r-prusa-edition-1.41.0.drv' failed

GrahamcOfBorg · 2018-10-02T23:02:57Z

Success on x86_64-linux (full log)

Attempted: slic3r-prusa3d

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0
shrinking /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/lib/slic3r-prusa3d/auto/Slic3r/XS/XS.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/lib  /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/bin
patching script interpreter paths in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0
/nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/bin/.slic3r-prusa3d-wrapped: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/hjn5kq7yq18z31ajq7lfd6imjwz21lh6-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0...
/nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0

timokau · 2018-10-03T15:09:53Z

Any idea regarding the aarch64 failure?

Moredread · 2018-10-03T17:56:20Z

@timokau Sadly no, but it seems to happen during linking of libslic3r.a

Likely the problem has been happening in earlier versions though. #43102 also failed.

I've marked aarch64-linux as unsupported for now.

timokau · 2018-10-03T18:04:43Z

@GrahamcOfBorg build slic3r-prusa3d

GrahamcOfBorg · 2018-10-03T18:04:52Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slic3r-prusa3d

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-03T18:08:19Z

Failure on aarch64-linux (full log)

Attempted: slic3r-prusa3d

Partial log (click to expand)

/build/source/xs/src/libslic3r/PlaceholderParser.cpp:1000:72:   required from 'Slic3r::client::macro_processor<Iterator>::macro_processor() [with Iterator = __gnu_cxx::__normal_iterator<const char*, std::__cxx11::basic_string<char> >]'
/build/source/xs/src/libslic3r/PlaceholderParser.cpp:1180:33:   required from here
/build/source/xs/src/libslic3r/PlaceholderParser.cpp:462:32: warning: unused variable 'mask' [-Wunused-variable]
             const std::string *mask     = nullptr;
                                ^~~~
[ 95%] Linking CXX static library liblibslic3r.a
[ 95%] Built target libslic3r
make: *** [Makefile:141: all] Error 2
builder for '/nix/store/z0my0l3v811ivgjsi7l589szcmg1yvbv-slic3r-prusa-edition-1.41.0.drv' failed with exit code 2
error: build of '/nix/store/z0my0l3v811ivgjsi7l589szcmg1yvbv-slic3r-prusa-edition-1.41.0.drv' failed

GrahamcOfBorg · 2018-10-03T18:10:17Z

Success on x86_64-linux (full log)

Attempted: slic3r-prusa3d

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0
shrinking /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/lib/slic3r-prusa3d/auto/Slic3r/XS/XS.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/lib  /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/bin
patching script interpreter paths in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0
/nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/bin/.slic3r-prusa3d-wrapped: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/hjn5kq7yq18z31ajq7lfd6imjwz21lh6-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0...
/nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0

timokau · 2018-10-03T18:28:08Z

Seems like that didn't work. I'm not sure what the best way to remove aarch64 from the platforms is. I've seen people explicitly specifying x86 and x86_64 explicitly, which doesn't really seem right to me either.

Moredread · 2018-10-03T19:01:58Z

@timokau I've posted on discourse (https://discourse.nixos.org/t/marking-a-package-broken-for-certain-platforms/1057) regarding this question.

Moredread · 2018-10-08T20:47:50Z

@timokau I've marked it as broken now. On my system it shows as broken when cross compiling. I have to wait for access to the aarch64 build host before I can work on that issue and would advocate for merging this PR in the meantime, as 1.41.0 is the first version that supports the Prusa MMU 2.0.

For that reason I would also like to backport this to 18.09.

timokau · 2018-10-09T15:01:04Z

@GrahamcOfBorg build slic3r-prusa3d

GrahamcOfBorg · 2018-10-09T15:01:21Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: slic3r-prusa3d

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-09T15:01:39Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slic3r-prusa3d

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-09T15:08:21Z

Success on x86_64-linux (full log)

Attempted: slic3r-prusa3d

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0
shrinking /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/lib/slic3r-prusa3d/auto/Slic3r/XS/XS.so
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/lib  /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/bin
patching script interpreter paths in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0
/nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0/bin/.slic3r-prusa3d-wrapped: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/hjn5kq7yq18z31ajq7lfd6imjwz21lh6-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0...
/nix/store/dbxa9wbqdr0ckfzd0qh89kgv6pvw8fc5-slic3r-prusa-edition-1.41.0

timokau · 2018-10-09T15:19:50Z

Thank you, looks good! The aarch64 support probably isn't so essential that you must spent much time on it if you don't want to.

would advocate for merging this PR in the meantime, as 1.41.0 is the first version that supports the Prusa MMU 2.0.

The policy is to backport bug fixes and maybe additions, but not simply features. The reason for that is that every new feature has the potential to break something and the releases are supposed to be as stable as possible. You can however easily have a system based on the stable release and still install the latest version of some software from the unstable channel. The wiki has more info on that.

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jul 25, 2018

Moredread force-pushed the slic3r-prusa3d/1.41.0 branch from 440f774 to 3215e9c Compare August 7, 2018 13:43

Moredread force-pushed the slic3r-prusa3d/1.41.0 branch 2 times, most recently from 407b980 to d9d0bf0 Compare August 31, 2018 10:08

Moredread force-pushed the slic3r-prusa3d/1.41.0 branch from d9d0bf0 to 3d15bff Compare September 2, 2018 12:24

Moredread changed the title ~~[WIP] slic3r-prusa3d: 1.40.1 -> 1.41.0~~ slic3r-prusa3d: 1.40.1 -> 1.41.0 Sep 2, 2018

timokau requested changes Oct 1, 2018

View reviewed changes

Moredread force-pushed the slic3r-prusa3d/1.41.0 branch from 3d15bff to cddf6a5 Compare October 2, 2018 07:30

timokau reviewed Oct 2, 2018

View reviewed changes

pkgs/applications/misc/slic3r/prusa3d.nix Outdated Show resolved Hide resolved

slic3r-prusa3d: comments on why we apply some patches

2125e07

Moredread force-pushed the slic3r-prusa3d/1.41.0 branch 2 times, most recently from 4bd1073 to 9b7a15a Compare October 2, 2018 19:46

timokau approved these changes Oct 2, 2018

View reviewed changes

slic3r-prusa3d: 1.40.1 -> 1.41.0

0dd86a3

Moredread force-pushed the slic3r-prusa3d/1.41.0 branch from 9b7a15a to 0dd86a3 Compare October 3, 2018 17:56

Moredread mentioned this pull request Oct 6, 2018

slic3r-prusa3d: 1.40.1 -> 1.41.0 #47983

Closed

4 tasks

slic3r-prusa3d: mark as broken on aarch64

5ebf16d

GrahamcOfBorg added the 8.has: clean-up label Oct 8, 2018

timokau merged commit 9fcfcf5 into NixOS:master Oct 9, 2018

Moredread deleted the slic3r-prusa3d/1.41.0 branch November 18, 2018 19:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

slic3r-prusa3d: 1.40.1 -> 1.41.0 #44077

slic3r-prusa3d: 1.40.1 -> 1.41.0 #44077

Moredread commented Jul 25, 2018 •

edited

Moredread commented Aug 31, 2018 •

edited

Moredread commented Sep 4, 2018

matthewbauer commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

timokau Oct 1, 2018

Moredread Oct 2, 2018 •

edited

timokau commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

timokau commented Oct 3, 2018

Moredread commented Oct 3, 2018

timokau commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

timokau commented Oct 3, 2018

Moredread commented Oct 3, 2018 •

edited

Moredread commented Oct 8, 2018 •

edited

timokau commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

timokau commented Oct 9, 2018

slic3r-prusa3d: 1.40.1 -> 1.41.0 #44077

slic3r-prusa3d: 1.40.1 -> 1.41.0 #44077

Conversation

Moredread commented Jul 25, 2018 • edited

Motivation for this change

Things done

Moredread commented Aug 31, 2018 • edited

Moredread commented Sep 4, 2018

matthewbauer commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

GrahamcOfBorg commented Sep 30, 2018

timokau Oct 1, 2018

Choose a reason for hiding this comment

Moredread Oct 2, 2018 • edited

Choose a reason for hiding this comment

timokau commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

timokau commented Oct 3, 2018

Moredread commented Oct 3, 2018

timokau commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

timokau commented Oct 3, 2018

Moredread commented Oct 3, 2018 • edited

Moredread commented Oct 8, 2018 • edited

timokau commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

GrahamcOfBorg commented Oct 9, 2018

timokau commented Oct 9, 2018

Moredread commented Jul 25, 2018 •

edited

Moredread commented Aug 31, 2018 •

edited

Moredread Oct 2, 2018 •

edited

Moredread commented Oct 3, 2018 •

edited

Moredread commented Oct 8, 2018 •

edited