Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick commit that fixes libreoffice wrapper to release-18.04 #44090

Merged
merged 2 commits into from Jul 26, 2018
Merged

Cherry-pick commit that fixes libreoffice wrapper to release-18.04 #44090

merged 2 commits into from Jul 26, 2018

Conversation

balsoft
Copy link
Member

@balsoft balsoft commented Jul 25, 2018 •
edited

Motivation for this change

This fixes #43801 by cherry-picking 1f52bfb and then correcting merging errors.

cc @7c6f434c

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@balsoft
Copy link
Member Author

balsoft commented Jul 25, 2018

This is what it looks like:
image

@7c6f434c 7c6f434c merged commit 7d85757 into NixOS:release-18.03 Jul 26, 2018
@balsoft balsoft mentioned this pull request Jul 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balsoft @7c6f434c @GrahamcOfBorg @Janik-Haag