Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: Init #44839

Closed
wants to merge 1 commit into from
Closed

nixos/nextcloud: Init #44839

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Aug 9, 2018

Motivation for this change

I'm using NextCloud and I'd prefer to have it packaged as a module and located in the nix store.

I hope this PR isn't too bad, it's the largest PR that I have done in this repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member Author

dasJ commented Aug 9, 2018

Oh, before anyone asks: I put some location blocks into extraConfig. I did that because their order matters and I didn't see another way to enforce their order.

@flokli flokli mentioned this pull request Aug 15, 2018
Closed
4 tasks
@flokli
Copy link
Contributor

flokli commented Aug 15, 2018

@dasJ Can you please also have a look at #44994, and on how much functionality is shared?

@globin
Copy link
Member

globin commented Aug 19, 2018

Most of the functionality is similar, #44994 is a bit cleaner in a few ways:

  • adds nginx location priority in order not have to specify locations in extraConfig
  • adds an autoconfig.php for initial setup

This PR OTOH adds a few more options for caching, I'll try to add them to #44994. Sorry for not seeing this earlier and causing duplicate work.

globin added a commit to mayflower/nixpkgs that referenced this pull request Aug 19, 2018
@globin @dasJ
nextcloud: incorporate improvements from NixOS#44839
9bdd7af 
Closes NixOS#44839

Co-authored-by: Janne Heß <janne@hess.ooo>
@globin
Copy link
Member

globin commented Aug 19, 2018

Improvements of this PR have been added to #44994

globin added a commit to mayflower/nixpkgs that referenced this pull request Aug 20, 2018
@globin @dasJ
nextcloud: incorporate improvements from NixOS#44839
5155e94 
Closes NixOS#44839

Co-authored-by: Janne Heß <janne@hess.ooo>
eqyiel pushed a commit to eqyiel/nixpkgs that referenced this pull request Sep 25, 2018
@globin @dasJ @eqyiel
nextcloud: incorporate improvements from NixOS#44839
52e8305 
Closes NixOS#44839

Co-authored-by: Janne Heß <janne@hess.ooo>
@flokli
Copy link
Contributor

flokli commented Oct 1, 2018

@Mic92 this can be closed, as it was incorporated into #44839, which was continued in #47159.

@Mic92 Mic92 closed this Oct 1, 2018
@dasJ dasJ deleted the nc-module branch October 6, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasJ @flokli @globin @Mic92 @GrahamcOfBorg