mruby: init at 1.4.1 #44840
Merged
mruby: init at 1.4.1 #44840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build mruby |
|
Failure on x86_64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mruby Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Hi! Thanks for your contribution. I personally was interested in the past into looking at Looked at the Linux building issue and fixed it in my branch here. This also adds the tests, disabling a test that fails on Linux. Feel free to rebase/squash into your commits. If you ever intend to not maintain the package, you can ping me in a PR removing yourself from maintaining it. If you feel fine with the changes, I can also push this directly to your branch, which will trigger a new build, and then merge if everything's fine. Just ask. For the record, if one needs to trace the build: diff --git a/pkgs/development/compilers/mruby/default.nix b/pkgs/development/compilers/mruby/default.nix
index b7213671f76..e68547151b1 100644
--- a/pkgs/development/compilers/mruby/default.nix
+++ b/pkgs/development/compilers/mruby/default.nix
@@ -23,6 +23,11 @@ stdenv.mkDerivation rec {
unset LD
'';
+ # To get a verbose build, directly use `minirake` instead of `make`.
+ buildPhase = ''
+ ruby ./minirake --trace
+ '';
+
installPhase = ''
mkdir $out
cp -R build/host/{bin,lib} $out
|
nicknovitski
force-pushed
the
mruby-init
branch
4 times, most recently
from
ff4fd6f
to
44dee02
Compare
|
@GrahamcOfBorg build mruby |
|
Failure on aarch64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mruby Partial log (click to expand)
|
|
@xeji Sorry, I was pushing possible fixes in order to easily have the expressions available to a linux build environment, but none of them ended up working @samueldr Thank you! Feel free to push those changes, and make yourself a maintainer too; I don't mind the responsibility, but I also don't think of myself as an expert. |
Don't worry, being an expert isn't in itself required for being a maintainers. Sure it helps, but what's even better is caring for the package and somehow tracking its updates. I hope that, as a user, you'll keep track of mruby updates and provide the PRs as they come. @GrahamcOfBorg build mruby |
|
Failure on x86_64-darwin (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Oh, interesting how the @GrahamcOfBorg build mruby |
I'm not sure of the semantics of `gcc` vs. `ld` for linking, but it makes the difference between working and: ``` /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/ld: warning: cannot find entry symbol _start; defaulting to 0000000000401100 ```
|
Success on x86_64-darwin (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mruby Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mruby Partial log (click to expand)
|
xeji
approved these changes
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm surprised it wasn't already in the repository.
sandboxinnix.confon non-NixOS)[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)[ ] Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)[ ] Determined the impact on package closure size (by runningnix path-info -Sbefore and after)