Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: make package configurable #44848

Merged
merged 1 commit into from Aug 10, 2018
Merged

vault: make package configurable #44848

merged 1 commit into from Aug 10, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Aug 9, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member Author

LnL7 commented Aug 9, 2018

@GrahamcOfBorg test vault

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.vault

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 7.73s
cleaning up
killing machine (pid 600)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/jpfnq9bz6ycwqs4iaq1wfhxy46czacx2-vm-test-run-vault

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: tests.vault

Partial log (click to expand)

cannot build derivation '/nix/store/flai5fzm9xxgdngb2g0vv6cb5jxnrh9s-etc.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/q6glqxqrkmyk6jmy5mp00c0jj5p3xz9q-stage-1-init.sh.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jin80y97524arw8k2vk12inwfscywl6y-initrd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k100h7wvd0ydr447slkpq08pcx8ja8ch-nixos-system-machine-18.09.git.572f948.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/7g8qy1wkyrf5c6b98i4nv5lqhb2h7z61-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bd7sx190q1nlhwamywd0139v1wfli7vm-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/rrqyz4jndyvyygs9hx27vxp8fn90pb0i-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/1123w4xmpff2zw8rgx4s3za1xmfjvlns-nixos-test-driver-vault.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1qiqiyx6372hcmvqn0b81n9g5dh3wxg6-vm-test-run-vault.drv': 1 dependencies couldn't be built
error: build of '/nix/store/1qiqiyx6372hcmvqn0b81n9g5dh3wxg6-vm-test-run-vault.drv' failed

@srhb srhb merged commit ddde09d into NixOS:master Aug 10, 2018
@LnL7 LnL7 deleted the vault-options branch August 10, 2018 17:27
@infinisil infinisil mentioned this pull request Nov 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @srhb