Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remake: fix build with glibc2.27 #44838

Merged
merged 1 commit into from Aug 9, 2018
Merged

remake: fix build with glibc2.27 #44838

merged 1 commit into from Aug 9, 2018

Conversation

infinisil
Copy link
Member

Same fix as applied for gnumake in 519f0b8

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
remake: fix build with glibc2.27
2583123 
Same fix as applied for gnumake in 519f0b8
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: remake

Partial log (click to expand)

make[1]: Leaving directory '/build/remake-4.1+dbg1.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mhrabhwnzhrflm4x9q1chwhl976k3v83-remake-4.1+dbg-1.1
/nix/store/mhrabhwnzhrflm4x9q1chwhl976k3v83-remake-4.1+dbg-1.1
shrinking /nix/store/mhrabhwnzhrflm4x9q1chwhl976k3v83-remake-4.1+dbg-1.1/bin/remake
gzipping man pages under /nix/store/mhrabhwnzhrflm4x9q1chwhl976k3v83-remake-4.1+dbg-1.1/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mhrabhwnzhrflm4x9q1chwhl976k3v83-remake-4.1+dbg-1.1/bin
patching script interpreter paths in /nix/store/mhrabhwnzhrflm4x9q1chwhl976k3v83-remake-4.1+dbg-1.1
checking for references to /build in /nix/store/mhrabhwnzhrflm4x9q1chwhl976k3v83-remake-4.1+dbg-1.1...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: remake

Partial log (click to expand)

make[1]: Leaving directory '/build/remake-4.1+dbg1.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aaqbnar10kpf5zms6ajh598as0x30qd4-remake-4.1+dbg-1.1
shrinking /nix/store/aaqbnar10kpf5zms6ajh598as0x30qd4-remake-4.1+dbg-1.1/bin/remake
gzipping man pages under /nix/store/aaqbnar10kpf5zms6ajh598as0x30qd4-remake-4.1+dbg-1.1/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aaqbnar10kpf5zms6ajh598as0x30qd4-remake-4.1+dbg-1.1/bin
patching script interpreter paths in /nix/store/aaqbnar10kpf5zms6ajh598as0x30qd4-remake-4.1+dbg-1.1
checking for references to /build in /nix/store/aaqbnar10kpf5zms6ajh598as0x30qd4-remake-4.1+dbg-1.1...
/nix/store/aaqbnar10kpf5zms6ajh598as0x30qd4-remake-4.1+dbg-1.1

@infinisil infinisil merged commit faf2821 into NixOS:master Aug 9, 2018
@infinisil infinisil deleted the fix/remake branch August 9, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @GrahamcOfBorg