Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosml: init at 2.10.1 #44859

Merged
merged 1 commit into from Aug 10, 2018
Merged

mosml: init at 2.10.1 #44859

merged 1 commit into from Aug 10, 2018

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Aug 10, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vaibhavsagar vaibhavsagar force-pushed the mosml-init branch 3 times, most recently from b1ef006 to 91f3195 Compare August 10, 2018 07:45
@srhb
Copy link
Contributor

srhb commented Aug 10, 2018

@GrahamcOfBorg build mosml

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mosml

Partial log (click to expand)

shrinking /nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1/lib/mosml/libmgmp.so
shrinking /nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1/lib/mosml/libmunix.so
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1/lib  /nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1/bin 
patching script interpreter paths in /nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1
/nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1/bin/mosml: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1/bin/mosmllex: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
/nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1/bin/mosmlc: interpreter directive changed from "/bin/sh" to "/nix/store/56nrxy58wbhvs2sy3rir1jqa68p0kkm5-bash-4.4-p23/bin/sh"
checking for references to /tmp/nix-build-mosml-2.10.1.drv-0 in /nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1...
/nix/store/2y8mpsbmsj4kwvv50qj381rckdrp41p4-mosml-2.10.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: mosml

Partial log (click to expand)

make[1]: Entering directory '/private/tmp/nix-build-mosml-2.10.1.drv-0/mosml-ver-2.10.1/src/config'
sh autoconf gcc
Checking the sizes of integers and pointers...
This architecture seems to be neither 32 bits nor 64 bits.
Caml Light won't run on this architecture.
make[1]: *** [Makefile:13: runtime] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-mosml-2.10.1.drv-0/mosml-ver-2.10.1/src/config'
make: *** [Makefile:26: world] Error 2
builder for '/nix/store/xi9md20vq8fsy93da1rg74nqvy4xnc1y-mosml-2.10.1.drv' failed with exit code 2
error: build of '/nix/store/xi9md20vq8fsy93da1rg74nqvy4xnc1y-mosml-2.10.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mosml

Partial log (click to expand)

shrinking /nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1/bin/mosmlyac
shrinking /nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1/bin/camlrunm
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1/lib  /nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1/bin
patching script interpreter paths in /nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1
/nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1/bin/mosmllex: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1/bin/mosmlc: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
/nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1/bin/mosml: interpreter directive changed from "/bin/sh" to "/nix/store/7q3ayirslrcva28wava6zpjcflcz1h3b-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1...
/nix/store/2l2c36cxgq1v3km4jmpk47ngr0dxhrhy-mosml-2.10.1

@srhb
Copy link
Contributor

srhb commented Aug 10, 2018

@vaibhavsagar Did you manage to build it on Darwin?

@vaibhavsagar
Copy link
Member Author

I didn't try on macOS, but I assumed it would work ☹️

@srhb
Copy link
Contributor

srhb commented Aug 10, 2018

Yeah, strange. People of the future, it has been mentioned at least here: kfl/mosml#47 (comment)

@srhb
Copy link
Contributor

srhb commented Aug 10, 2018

And thanks!

@srhb srhb merged commit 62eab59 into NixOS:master Aug 10, 2018
@vaibhavsagar
Copy link
Member Author

My pleasure 😄!

@vaibhavsagar vaibhavsagar deleted the mosml-init branch August 10, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @srhb @GrahamcOfBorg