Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libinotify-kqueue: init at 20180201 #44852

Merged
merged 2 commits into from Aug 10, 2018
Merged

libinotify-kqueue: init at 20180201 #44852

merged 2 commits into from Aug 10, 2018

Conversation

lukateras
Copy link
Member

Motivation for this change

https://github.com/libinotify-kqueue/libinotify-kqueue

Inotify shim for systems with Kqueue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lukateras lukateras force-pushed the 20180810.025530/libinotify-kqueue branch from 30eeab5 to f4c2ee0 Compare August 10, 2018 00:10
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: libinotify-kqueue

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: libinotify-kqueue

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libinotify-kqueue

Partial log (click to expand)

(cd /nix/store/gbvy2qw9vs2zxhcgspfxfjzgy56a9cgf-libinotify-kqueue-20180201/share/man/man3 && rm -f inotify_set_param.3 && ln -s libinotify.3 inotify_set_param.3)
(cd /nix/store/gbvy2qw9vs2zxhcgspfxfjzgy56a9cgf-libinotify-kqueue-20180201/share/man/man3 && rm -f inotify_event.3 && ln -s libinotify.3 inotify_event.3)
make[2]: Leaving directory '/private/tmp/nix-build-libinotify-kqueue-20180201.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-libinotify-kqueue-20180201.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/gbvy2qw9vs2zxhcgspfxfjzgy56a9cgf-libinotify-kqueue-20180201/share/man/
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gbvy2qw9vs2zxhcgspfxfjzgy56a9cgf-libinotify-kqueue-20180201/lib
patching script interpreter paths in /nix/store/gbvy2qw9vs2zxhcgspfxfjzgy56a9cgf-libinotify-kqueue-20180201
/nix/store/gbvy2qw9vs2zxhcgspfxfjzgy56a9cgf-libinotify-kqueue-20180201

@lukateras lukateras mentioned this pull request Aug 10, 2018
Open
@xeji
Copy link
Contributor

xeji commented Aug 10, 2018

Did you try to run the tests provided by upstream?

@lukateras lukateras force-pushed the 20180810.025530/libinotify-kqueue branch from 6a8ce49 to 6f35084 Compare August 10, 2018 09:27
@lukateras
Copy link
Member Author

I've enabled tests and it passes on macOS.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: libinotify-kqueue

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: libinotify-kqueue

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libinotify-kqueue

Partial log (click to expand)

(cd /nix/store/0w1my2bz5mnv1iql71zdfkvmnkg28yaf-libinotify-kqueue-20180201/share/man/man3 && rm -f inotify_set_param.3 && ln -s libinotify.3 inotify_set_param.3)
(cd /nix/store/0w1my2bz5mnv1iql71zdfkvmnkg28yaf-libinotify-kqueue-20180201/share/man/man3 && rm -f inotify_event.3 && ln -s libinotify.3 inotify_event.3)
make[2]: Leaving directory '/private/tmp/nix-build-libinotify-kqueue-20180201.drv-0/source'
make[1]: Leaving directory '/private/tmp/nix-build-libinotify-kqueue-20180201.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/0w1my2bz5mnv1iql71zdfkvmnkg28yaf-libinotify-kqueue-20180201/share/man/
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0w1my2bz5mnv1iql71zdfkvmnkg28yaf-libinotify-kqueue-20180201/lib
patching script interpreter paths in /nix/store/0w1my2bz5mnv1iql71zdfkvmnkg28yaf-libinotify-kqueue-20180201
/nix/store/0w1my2bz5mnv1iql71zdfkvmnkg28yaf-libinotify-kqueue-20180201

@xeji xeji merged commit ccd9fdd into NixOS:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @GrahamcOfBorg @xeji