Read bundles with configparser #3137
Merged
+132
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Kwpolska
reviewed
Aug 10, 2018
CHANGES.txt
Outdated
| @@ -14,6 +14,8 @@ Features | |||
| "{postDate} (${messages("updated")} {updateDate})". If no update | |||
| time is specified, the posting time will be displayed alone. | |||
| * All built-in themes now support the ``DATE_FANCINESS`` option. | |||
| * Theme bundles are now parsed using the configparser module and | |||
| can support newlines inside entries as well ad comments | |||
Kwpolska
approved these changes
Aug 10, 2018
| @@ -0,0 +1 @@ | |||
| ../base/bundles | |||
There was a problem hiding this comment.
That symlink should not be necessary, as bundles are inherited.
| rst_base.css, | ||
| nikola_rst.css, | ||
| code.css, | ||
| theme.css, |
There was a problem hiding this comment.
Are the trailing commas (a) allowed or (b) necessary? (they are not in the manual examples)
There was a problem hiding this comment.
Allowed but not necessary.
|
Updated according to feedback. |
|
Thanks for contributing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
This PR changes the file parser for
bundlesfiles from a one-off parser to a modified configparser parser. The parser is modified to assume an opening[bundles]section rendering it fully backwards compatible with the existing file format.Doing so allows all existing files to parse as if nothing has changed and adds the full richness of configparser, importantly multiline values and comment (
#or;).I have gone on to split the core theme bundles across multiple lines.
This does not introduce any new dependencies and maintains strict backwards compatibility with existing themes/bundles.