Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginxMainline: 1.15.1 -> 1.15.2 #44431

Merged
merged 1 commit into from
Aug 4, 2018
Merged

nginxMainline: 1.15.1 -> 1.15.2 #44431

merged 1 commit into from
Aug 4, 2018
+2 −2

Conversation

jfrankenau
Copy link
Member

Motivation for this change

https://nginx.org/en/CHANGES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jfrankenau
nginxMainline: 1.15.1 -> 1.15.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
570f3bf
@Mic92
Copy link
Member

Mic92 commented Aug 3, 2018

@GrahamcOfBorg build nginxMainline

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nginxMainline

Partial log (click to expand)

test -d '/nix/store/vrpkfgy5nw72qpszp637z7ykv6ncvl86-nginx-1.15.2/logs' \
        || mkdir -p '/nix/store/vrpkfgy5nw72qpszp637z7ykv6ncvl86-nginx-1.15.2/logs'
make[1]: Leaving directory '/build/nginx-1.15.2'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vrpkfgy5nw72qpszp637z7ykv6ncvl86-nginx-1.15.2
shrinking /nix/store/vrpkfgy5nw72qpszp637z7ykv6ncvl86-nginx-1.15.2/bin/nginx
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vrpkfgy5nw72qpszp637z7ykv6ncvl86-nginx-1.15.2/bin
patching script interpreter paths in /nix/store/vrpkfgy5nw72qpszp637z7ykv6ncvl86-nginx-1.15.2
checking for references to /build in /nix/store/vrpkfgy5nw72qpszp637z7ykv6ncvl86-nginx-1.15.2...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nginxMainline

Partial log (click to expand)

        || mkdir -p '/nix/store/z7a3djcbwfyrk980madrcjb47v9f6x96-nginx-1.15.2/logs'
test -d '/nix/store/z7a3djcbwfyrk980madrcjb47v9f6x96-nginx-1.15.2/html' \
        || cp -R html '/nix/store/z7a3djcbwfyrk980madrcjb47v9f6x96-nginx-1.15.2'
test -d '/nix/store/z7a3djcbwfyrk980madrcjb47v9f6x96-nginx-1.15.2/logs' \
        || mkdir -p '/nix/store/z7a3djcbwfyrk980madrcjb47v9f6x96-nginx-1.15.2/logs'
make[1]: Leaving directory '/private/tmp/nix-build-nginx-1.15.2.drv-0/nginx-1.15.2'
post-installation fixup
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/z7a3djcbwfyrk980madrcjb47v9f6x96-nginx-1.15.2/bin
patching script interpreter paths in /nix/store/z7a3djcbwfyrk980madrcjb47v9f6x96-nginx-1.15.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nginxMainline

Partial log (click to expand)

        || mkdir -p '/nix/store/57gwpzs7ff13ssbq7fn5m7llhjwkp1b8-nginx-1.15.2/logs'
make[1]: Leaving directory '/build/nginx-1.15.2'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/57gwpzs7ff13ssbq7fn5m7llhjwkp1b8-nginx-1.15.2
shrinking /nix/store/57gwpzs7ff13ssbq7fn5m7llhjwkp1b8-nginx-1.15.2/bin/nginx
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/57gwpzs7ff13ssbq7fn5m7llhjwkp1b8-nginx-1.15.2/bin
patching script interpreter paths in /nix/store/57gwpzs7ff13ssbq7fn5m7llhjwkp1b8-nginx-1.15.2
checking for references to /build in /nix/store/57gwpzs7ff13ssbq7fn5m7llhjwkp1b8-nginx-1.15.2...
/nix/store/57gwpzs7ff13ssbq7fn5m7llhjwkp1b8-nginx-1.15.2

@LnL7
Copy link
Member

LnL7 commented Aug 3, 2018

@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

@GrahamcOfBorg test nginx

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

Sorry, ignore the test, it uses nginxStable.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.nginx

Partial log (click to expand)

webserver: exit status 1
syncing
webserver: running command: sync
webserver: exit status 0
test script finished in 18.53s
cleaning up
killing webserver (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/a7iv6ggl3rp96rjyzx64z31va24iwfbn-vm-test-run-nginx

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.nginx

Partial log (click to expand)

cannot build derivation '/nix/store/dqbxbfrj1k9z8mx9aqc9lq40yndhn30a-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/krphhfzyajjlz1n125hdv5igbcsa6p1s-stage-1-init.sh.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n6d0nxbl1wygcgvn2rwgzhqy5bblq3ry-initrd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xgrr2gsdn74c7cqq6hq5cd7pff6ahbd3-nixos-system-webserver-18.09.git.10a6b80.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/5fr84l0gcnqbd9qc0jdvpnq0m96hl248-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1p0w6fidbnhlx2z9z2z7b3bmg0libyc2-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0d9q2mb9kaixsmnvs2a8kcjl08i6ljhn-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/a1v969lh50q3ydv1ivb3q6djf6pr9c0v-nixos-test-driver-nginx.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/flibx0vvnz49c8sr7sw599kd7bmqf1rz-vm-test-run-nginx.drv': 1 dependencies couldn't be built
error: build of '/nix/store/flibx0vvnz49c8sr7sw599kd7bmqf1rz-vm-test-run-nginx.drv' failed

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

ran the test with this version locally. LGTM.

@xeji xeji merged commit c481117 into NixOS:master Aug 4, 2018
@jfrankenau jfrankenau deleted the update-nginx branch August 10, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jfrankenau @Mic92 @GrahamcOfBorg @LnL7 @xeji