Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php*Packages.oci8: init at 2.1.8 #44435

Merged
merged 1 commit into from Aug 5, 2018
Merged

php*Packages.oci8: init at 2.1.8 #44435

merged 1 commit into from Aug 5, 2018

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Aug 4, 2018

added the pecl oci8 library for php
had to make an adjustment to the oracle instantclient to make it compile

Motivation for this change

the php pecl oci8 library was missing from nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@aanderse
added the pecl oci8 library for php
4cc3a5a 
had to make an adjustment to the oracle instantclient to make it compile
@aanderse aanderse mentioned this pull request Aug 4, 2018
Closed
@aanderse aanderse changed the title added the pecl oci8 library for php php*Packages.oci8: init at 2.1.8 Aug 4, 2018
@infinisil
Copy link
Member

Went through the painful download of oracle stuff to check this out, even though I can't really test php as I have no idea about it. But stuff builds and this instantclient patch is really needed.

@infinisil infinisil merged commit e10db2f into NixOS:master Aug 5, 2018
@aanderse
Copy link
Member Author

aanderse commented Aug 5, 2018

I had never used this either but got one of the developers to send me a simple php example and db and it ran as expected.

Thank you for the merge!

@aanderse aanderse deleted the pecl-oci8 branch August 5, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @infinisil @GrahamcOfBorg @Janik-Haag