Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_shell: use python3 and buildPythonApplication #44418

Closed
wants to merge 2 commits into from
Closed

aws_shell: use python3 and buildPythonApplication #44418

wants to merge 2 commits into from

Conversation

dotlambda
Copy link
Member

Motivation for this change

#18185

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @muflax
Note that this has not been tested.

awscli: move to pythonPackages
c901743 
It is a dependency of aws_shell.
@dotlambda dotlambda requested a review from FRidh as a code owner August 3, 2018 17:44
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws_shell, awscli

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0/lib  /nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0/bin
patching script interpreter paths in /nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0
checking for references to /build in /nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0...
wrapping `/nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0/bin/aws-shell-mkindex'...
wrapping `/nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0/bin/aws-shell'...
/nix/store/0a454bzfnpfl9zaaqv3j8c2a3w40xgsa-aws-shell-0.2.0
/nix/store/vvd13h8r0pczgyiygfa0pdfjrp0f53br-python3.6-awscli-1.15.66

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws_shell, awscli

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0/lib  /nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0/bin
patching script interpreter paths in /nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0
checking for references to /build in /nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0...
wrapping `/nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0/bin/aws-shell'...
wrapping `/nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0/bin/aws-shell-mkindex'...
/nix/store/n9r54np79hchymr9hc4vgsqsk8k962dr-aws-shell-0.2.0
/nix/store/58ka2z5cdz4dcsfw2pyf2x0amymrmdzl-python3.6-awscli-1.15.66

@FRidh FRidh added this to the 19.09 milestone Jul 20, 2019
@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

Nothing happening so closing.

@FRidh FRidh closed this Jul 20, 2019
@dotlambda dotlambda deleted the aws_shell-python3 branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @GrahamcOfBorg @FRidh @xeji