signal-desktop: Allow overriding the spell checker language #44456
Conversation
Thought this could be useful for others as well. Unfortunately it will
also override the UI language.
Example usage:
environment.systemPackages = with pkgs; [
(signal-desktop.override {
spellcheckerLanguage = "de_DE";
})
];
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: signal-desktop Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: signal-desktop Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: signal-desktop Partial log (click to expand)
|
| then '' | ||
| --set HUNSPELL_DICTIONARIES "${hunspellDicts.${hunspellDict}}/share/hunspell" \ | ||
| --set LC_MESSAGES "${spellcheckerLanguage}"'' | ||
| else ""); |
There was a problem hiding this comment.
You already merged it, but these parens are unnecessary
There was a problem hiding this comment.
@infinisil Are you sure? You mean something like --set LC_MESSAGES "$spellcheckerLanguage"'', right? Normally that would work because Nix would create a corresponding shell variable for the attribute (IIRC this is done for all attributes passed to mkDerivation, if they're "representable in Bash"). But since the scope of e.g. spellcheckerLanguage is limited (by let ... in ...) the variable is never passed to mkDerivation and I therefore have to use the (Nix expression language) variable instead of the Bash variable. Or am I missing something?
There was a problem hiding this comment.
Oh, nvm, you've probably meant the parentheses around the if, yeah, I've missed that...
) Thought this could be useful for others as well. Unfortunately it will also override the UI language. Example usage: environment.systemPackages = with pkgs; [ (signal-desktop.override { spellcheckerLanguage = "de_DE"; }) ]; (cherry picked from commit 9ef1406)
…44456)" This reverts commit 9ef1406. Signal Desktop removed this functionality when changing spell checkers: - signalapp/Signal-Desktop@6a517e4 - signalapp/Signal-Desktop@4a8f5db
…44456)" This reverts commit 9ef1406. Signal Desktop removed this functionality when changing spell checkers: - signalapp/Signal-Desktop@6a517e4 - signalapp/Signal-Desktop@4a8f5db (cherry picked from commit cb7ddc7)
Thought this could be useful for others as well. Unfortunately it will
also override the UI language.
Example usage:
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Known problems: Apparently umlauts don't work correctly...