Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squashfuse : unstable-2018-02-20 -> 0.1.103 #44450

Merged
merged 1 commit into from Aug 5, 2018
Merged

squashfuse : unstable-2018-02-20 -> 0.1.103 #44450

merged 1 commit into from Aug 5, 2018

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Aug 4, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Aug 4, 2018
View reviewed changes
pkgs/tools/filesystems/squashfuse/default.nix Outdated
sha256 = "07jv4qjjz9ky3mw3p5prgs19g1bna9dcd7jjdz8083s1wyipdgcq";
src = fetchurl {
url = "https://github.com/vasi/squashfuse/archive/${version}.tar.gz";
sha256 = "1pfh46b6r2pd0i12sgf6w9hb0n3wcx3m2a9clfar33sx8gz319dv";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to switch to fetchurl, use fetchFromGitHub

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

@GrahamcOfBorg build squashfuse

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: squashfuse

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: squashfuse

Partial log (click to expand)

shrinking /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103/bin/squashfuse_ll
shrinking /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103/bin/squashfuse
shrinking /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103/lib/libfuseprivate.so.0.0.0
shrinking /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103/lib/libsquashfuse.so.0.0.0
gzipping man pages under /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103/lib  /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103/bin
patching script interpreter paths in /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103
checking for references to /build in /nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103...
/nix/store/03ifz7wx7rbzdi0wawqhddaiglgp0kk2-squashfuse-0.1.103

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: squashfuse

Partial log (click to expand)

shrinking /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103/bin/squashfuse_ll
shrinking /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103/bin/squashfuse
shrinking /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103/lib/libfuseprivate.so.0.0.0
shrinking /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103/lib/libsquashfuse.so.0.0.0
gzipping man pages under /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103/lib  /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103/bin
patching script interpreter paths in /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103
checking for references to /build in /nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103...
/nix/store/07cz5bsv33za90j9ncnszrh2zrwsg5vk-squashfuse-0.1.103

xeji
xeji approved these changes Aug 4, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments were resolved. LGTM.

@infinisil
Copy link
Member

Was this tested by anybody, @bignaux?

@bignaux
Copy link
Contributor Author

bignaux commented Aug 5, 2018

i've tested it, works well.

@infinisil infinisil merged commit 0aa19ba into NixOS:master Aug 5, 2018
@bignaux bignaux deleted the squashfuse branch August 5, 2018 15:12
@lpetre lpetre mentioned this pull request Jul 23, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bignaux @xeji @GrahamcOfBorg @infinisil