Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_34: remove unused #44452

Merged
merged 1 commit into from Aug 23, 2018
Merged

llvmPackages_34: remove unused #44452

merged 1 commit into from Aug 23, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Aug 4, 2018

Motivation for this change

See #44372. cc @dezgeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Aug 4, 2018 •
edited

cc @dtzWill
In research often old versions are needed because projects cannot keep up with the development speed of llvm. Outside of that community there are probably not to many users of those packages. That being said we probably should not remove all old llvm packages. I don't have a particular opinion on that one.

@vcunat
Copy link
Member

vcunat commented Aug 4, 2018 •
edited

👍 3.5 is almost four years old, so I'd expect that's sufficient time for projects having moved on.

@xeji xeji merged commit 058ab4c into NixOS:master Aug 23, 2018
@LnL7
Copy link
Member

LnL7 commented Aug 23, 2018

It wasn't removed with the last cleanup because there was still some stuff that needed it, but those seem to have been removed or updated now.

@FRidh FRidh deleted the llvm_34 branch August 24, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FRidh @Mic92 @vcunat @LnL7 @GrahamcOfBorg @xeji