Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: 238 -> 239 #44451

Merged
merged 1 commit into from Aug 6, 2018
Merged

systemd: 238 -> 239 #44451

merged 1 commit into from Aug 6, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 4, 2018 •
edited

Motivation for this change

So far I run boot tests and booted systemd on my laptop.
We should take a look if interface renaming still works, there were updates in systemd-udevd for net-id builtin.

Changelog: https://github.com/systemd/systemd/blob/fcb975129693d2d82dafb839fa66b9ac027bb080/NEWS#L30

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systemd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: systemd

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/8p7h9k818vb8js8ks74fzppkmiyvyiw0-systemd-239-man
gzipping man pages under /nix/store/8p7h9k818vb8js8ks74fzppkmiyvyiw0-systemd-239-man/share/man/
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8p7h9k818vb8js8ks74fzppkmiyvyiw0-systemd-239-man
checking for references to /build in /nix/store/8p7h9k818vb8js8ks74fzppkmiyvyiw0-systemd-239-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/53rvhqqyj1sbxx52wxvvrsj7rbi8g0n7-systemd-239-dev
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/53rvhqqyj1sbxx52wxvvrsj7rbi8g0n7-systemd-239-dev/lib
patching script interpreter paths in /nix/store/53rvhqqyj1sbxx52wxvvrsj7rbi8g0n7-systemd-239-dev
checking for references to /build in /nix/store/53rvhqqyj1sbxx52wxvvrsj7rbi8g0n7-systemd-239-dev...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd

Partial log (click to expand)

gzipping man pages under /nix/store/g8lb4gvm2m06ypadyyay4xkk8rx37qnv-systemd-239-man/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/g8lb4gvm2m06ypadyyay4xkk8rx37qnv-systemd-239-man
checking for references to /build in /nix/store/g8lb4gvm2m06ypadyyay4xkk8rx37qnv-systemd-239-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/847k4km0585vwiilik042r8qx7nxqxsz-systemd-239-dev
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/847k4km0585vwiilik042r8qx7nxqxsz-systemd-239-dev/lib
patching script interpreter paths in /nix/store/847k4km0585vwiilik042r8qx7nxqxsz-systemd-239-dev
checking for references to /build in /nix/store/847k4km0585vwiilik042r8qx7nxqxsz-systemd-239-dev...
/nix/store/52whvq4c7ca73b18zlxi75qz36zcz4lq-systemd-239

@FRidh
Copy link
Member

FRidh commented Aug 4, 2018

This should go to staging.

@Mic92 Mic92 changed the base branch from master to staging August 4, 2018 12:53
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: systemd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: systemd

Partial log (click to expand)

cannot build derivation '/nix/store/wp1sqd9zicjmnn98livpd2z6c48rrw90-libmicrohttpd-0.9.59.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/x2pzl19j76yg9ivsxhrp6i8cfc74kzi4-meson-0.46.1.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/6ibhg5gcz67r9r1xdn1r2armxndwfhiz-python3.6-lxml-4.2.3.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/8d51zvp8sdizmzspgvi9xxlx4x30s1yj-gnome-doc-utils-0.20.10.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/yc64gr5wb7180x217avlzrvcsr8w7s6s-python3-3.6.6-env.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/pr8s1yiypyv89gvb5k3pf8i6jgxlz740-shadow-4.5.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/f1ixb3i6zn1r4k5vxfh4xiwhhn9jg1x8-util-linux-2.32.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/c7m1gr6d9973s021is1jc095hl8cgr6x-glib-2.56.0.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/8r0ghrdydqxdc80g8fzycgrlzf448hvg-systemd-239.drv': 43 dependencies couldn't be built
error: build of '/nix/store/8r0ghrdydqxdc80g8fzycgrlzf448hvg-systemd-239.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: systemd

Partial log (click to expand)

gzipping man pages under /nix/store/55c10hb3j8b7nh6wdhpyhsr2byl3fp9x-systemd-239-man/share/man/
strip is /nix/store/9j0pcdyfj2lmp9p4532h9n8wzrj1ms8p-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/55c10hb3j8b7nh6wdhpyhsr2byl3fp9x-systemd-239-man
checking for references to /build in /nix/store/55c10hb3j8b7nh6wdhpyhsr2byl3fp9x-systemd-239-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/yfl943xhiks3xhn2szyacfc632768p8n-systemd-239-dev
strip is /nix/store/9j0pcdyfj2lmp9p4532h9n8wzrj1ms8p-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yfl943xhiks3xhn2szyacfc632768p8n-systemd-239-dev/lib
patching script interpreter paths in /nix/store/yfl943xhiks3xhn2szyacfc632768p8n-systemd-239-dev
checking for references to /build in /nix/store/yfl943xhiks3xhn2szyacfc632768p8n-systemd-239-dev...
/nix/store/mzkfn3x0fs09qmhfj5n3cp2cy1w10whl-systemd-239

Mic92
Mic92 commented Aug 5, 2018
View reviewed changes
pkgs/os-specific/linux/systemd/default.nix
})
];

hardeningDisable = [ "stackprotector" ];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpletz can you recall, why this was disabled? It seems to compile for me, but I am not sure, if it has any effects at runtime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most probably it didn't build at the time, if I recall correctly it was systemd-boot that failed. I'm quite sure it was at build time but nonetheless it might be good to try the bootloader test. I'll give it a shot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run nixos/tests/boot.nix earlier and also use systemd-boot on my own system.

@globin globin merged commit 05daf39 into NixOS:staging Aug 6, 2018
@Mic92 Mic92 deleted the systemd-239 branch August 6, 2018 09:49
@Mic92 Mic92 mentioned this pull request Aug 6, 2018
Closed
@Mic92
Copy link
Member Author

Mic92 commented Aug 6, 2018

related to #44338

@fpletz
Copy link
Member

fpletz commented Aug 6, 2018

Cool! Thanks a lot! 👍

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Merge failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Merge failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Merge failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Merge failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin globin left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @GrahamcOfBorg @FRidh @fpletz @globin