Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-simg2img: init at 1.1.3 #44444

Closed
wants to merge 1 commit into from
Closed

android-simg2img: init at 1.1.3 #44444

wants to merge 1 commit into from

Conversation

AJChapman
Copy link
Contributor

@AJChapman AJChapman commented Aug 4, 2018 •
edited

Motivation for this change

I needed simg2img!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Aug 4, 2018

It's already in pkgs/tools/filesystems/simg2img/default.nix.

@pSub
Copy link
Member

pSub commented Aug 4, 2018

Closing as it is, as @dezgeg mentioned, already present at pkgs/tools/filesystems/simg2img/default.nix and almost identical.

@pSub pSub closed this Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AJChapman @dezgeg @pSub @GrahamcOfBorg