Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Apache-AuthCookie: init at 3.27 #44437

Merged
merged 2 commits into from Aug 4, 2018
Merged

perlPackages.Apache-AuthCookie: init at 3.27 #44437

merged 2 commits into from Aug 4, 2018

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Aug 4, 2018

added the apache auth cookie perl module

Motivation for this change

the apache auth cookie perl module was missing from nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@aanderse aanderse mentioned this pull request Aug 4, 2018
Closed
@Mic92
Copy link
Member

Mic92 commented Aug 4, 2018

@GrahamcOfBorg build perlPackages.ApacheAuthCookie

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: perlPackages.ApacheAuthCookie

Partial log (click to expand)

post-installation fixup
Moving /nix/store/in8sz1i4d66y8xgyam78q1w3xhz0gv34-perl-Apache-AuthCookie-3.27/share/man/man3 to /nix/store/2gxm4xvaxfrsaxmq1kl9rwspfkyvz2w1-perl-Apache-AuthCookie-3.27-devdoc/share/man/man3
Removing empty /nix/store/in8sz1i4d66y8xgyam78q1w3xhz0gv34-perl-Apache-AuthCookie-3.27/share/man/ and (possibly) its parents
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/in8sz1i4d66y8xgyam78q1w3xhz0gv34-perl-Apache-AuthCookie-3.27/lib
patching script interpreter paths in /nix/store/in8sz1i4d66y8xgyam78q1w3xhz0gv34-perl-Apache-AuthCookie-3.27
gzipping man pages under /nix/store/2gxm4xvaxfrsaxmq1kl9rwspfkyvz2w1-perl-Apache-AuthCookie-3.27-devdoc/share/man/
strip is /nix/store/qfxcr8c4fg7lkybrny9n2sb77bmippdx-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/2gxm4xvaxfrsaxmq1kl9rwspfkyvz2w1-perl-Apache-AuthCookie-3.27-devdoc
/nix/store/in8sz1i4d66y8xgyam78q1w3xhz0gv34-perl-Apache-AuthCookie-3.27

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: perlPackages.ApacheAuthCookie

Partial log (click to expand)

running tests
check flags: SHELL=/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/bash VERBOSE=y test
"/nix/store/k15ac8wk8h7r30y6g6z5j6rahc28aanm-perl-5.24.4/bin/perl" -Iblib/arch -Iblib/lib \
t/TEST  -clean
[warning] setting ulimit to allow core files
ulimit -c unlimited; /nix/store/k15ac8wk8h7r30y6g6z5j6rahc28aanm-perl-5.24.4/bin/perl /build/Apache-AuthCookie-3.27/t/TEST -clean
Use of uninitialized value $proto in socket at /nix/store/2bayjm0h6py5ska3jg229lrqyiijfj8h-perl-Apache-Test-1.40/lib/perl5/site_perl/5.24.4/aarch64-linux-thread-multi/Apache/TestServer.pm line 383.
make: *** [Makefile:910: test_clean] Error 2
builder for '/nix/store/jhdwkmfm21hhrm5a53gdzbl4x2pqpb24-perl-Apache-AuthCookie-3.27.drv' failed with exit code 2
error: build of '/nix/store/jhdwkmfm21hhrm5a53gdzbl4x2pqpb24-perl-Apache-AuthCookie-3.27.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: perlPackages.ApacheAuthCookie

Partial log (click to expand)

running tests
check flags: SHELL=/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/bash VERBOSE=y test
"/nix/store/9wd0qq24kqkn0jrz1kzh293k5p869im9-perl-5.24.4/bin/perl" -Iblib/arch -Iblib/lib \
t/TEST  -clean
[warning] setting ulimit to allow core files
ulimit -c unlimited; /nix/store/9wd0qq24kqkn0jrz1kzh293k5p869im9-perl-5.24.4/bin/perl /build/Apache-AuthCookie-3.27/t/TEST -clean
Use of uninitialized value $proto in socket at /nix/store/vxl9imbfrsa2v2wyb6ghcjzggad9qzpz-perl-Apache-Test-1.40/lib/perl5/site_perl/5.24.4/x86_64-linux-thread-multi/Apache/TestServer.pm line 383.
make: *** [Makefile:910: test_clean] Error 2
builder for '/nix/store/jah61dzcz4rwdbbxs17nh60b3hkznsgc-perl-Apache-AuthCookie-3.27.drv' failed with exit code 2
error: build of '/nix/store/jah61dzcz4rwdbbxs17nh60b3hkznsgc-perl-Apache-AuthCookie-3.27.drv' failed

@Mic92 Mic92 changed the title added the apache auth cookie perl module to nixpkgs perlPackages.Apache-AuthCookie: init at 3.27 Aug 4, 2018
@Mic92 Mic92 merged commit 20f1388 into NixOS:master Aug 4, 2018
@Mic92
Copy link
Member

Mic92 commented Aug 4, 2018

Also adapted commit title on squash to match with our convention.

@aanderse
Copy link
Member Author

aanderse commented Aug 4, 2018

I'm a bit confused here as why this built on my machine without failing. I cloned the nixpkgs repo, made my changes, and then rebuilt the system using my branch (via nixops deploy -I nixpkgs=path/to/my/branch). There were no errors and I ran code to test that this worked. Is there anything obvious I did wrong?

Regardless, I appreciate your fix and merge.

Thank you!

@aanderse aanderse deleted the apache-auth-cookie branch August 4, 2018 12:00
@Mic92
Copy link
Member

Mic92 commented Aug 6, 2018

You did run nix without sandboxing enabled. Inside the sandbox there is no /etc/protocols, which the test loaded.

@aanderse
Copy link
Member Author

aanderse commented Aug 6, 2018

Ah yes that makes sense. Thank you so much, I'll know for next time now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @Mic92 @GrahamcOfBorg