Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg{,-full}: 3.4.3 -> 3.4.4 (18.03 backport) #44448

Merged
merged 1 commit into from Aug 4, 2018
Merged

ffmpeg{,-full}: 3.4.3 -> 3.4.4 (18.03 backport) #44448

merged 1 commit into from Aug 4, 2018

Conversation

mat8913
Copy link
Contributor

@mat8913 mat8913 commented Aug 4, 2018

Motivation for this change

Fixes #44256

(cherry picked from commit 4f505d7)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vcunat vcunat self-assigned this Aug 4, 2018
@vcunat
Copy link
Member

vcunat commented Aug 4, 2018

Let's test darwin.
@GrahamcOfBorg build ffmpeg

@vcunat
Copy link
Member

vcunat commented Aug 4, 2018

@GrahamcOfBorg build ffmpeg

@vcunat
Copy link
Member

vcunat commented Aug 4, 2018

Claims to fix CVE-2018-14395.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ffmpeg

Partial log (click to expand)

find: '/nix/store/7iipb0q2nmxdmrf64cickp54svipvv26-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/7iipb0q2nmxdmrf64cickp54svipvv26-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/7iipb0q2nmxdmrf64cickp54svipvv26-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/7iipb0q2nmxdmrf64cickp54svipvv26-ffmpeg-3.4.4-doc': No such file or directory
find: '/nix/store/7iipb0q2nmxdmrf64cickp54svipvv26-ffmpeg-3.4.4-doc': No such file or directory
Moving /nix/store/9v67jb67icfsafd8rs735d2ban2n7m54-ffmpeg-3.4.4/bin to /nix/store/lm8xg4dl4qp1ynsfdxqik72ykm9yn5sk-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/9v67jb67icfsafd8rs735d2ban2n7m54-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/9v67jb67icfsafd8rs735d2ban2n7m54-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/7iipb0q2nmxdmrf64cickp54svipvv26-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/9v67jb67icfsafd8rs735d2ban2n7m54-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
/nix/store/lm8xg4dl4qp1ynsfdxqik72ykm9yn5sk-ffmpeg-3.4.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ffmpeg

Partial log (click to expand)

/nix/store/lm8xg4dl4qp1ynsfdxqik72ykm9yn5sk-ffmpeg-3.4.4-bin

@vcunat vcunat merged commit 70c0b6f into NixOS:release-18.03 Aug 4, 2018
vcunat added a commit that referenced this pull request Aug 4, 2018
@vcunat
Merge #44448: ffmpeg{,-full}: 3.4.3 -> 3.4.4 (security)
3af0010
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

gzipping man pages under /nix/store/dvaffxb23d0m6nmlyxnib6jfifyh0gql-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/dvaffxb23d0m6nmlyxnib6jfifyh0gql-ffmpeg-3.4.4-man
checking for references to /tmp/nix-build-ffmpeg-3.4.4.drv-0 in /nix/store/dvaffxb23d0m6nmlyxnib6jfifyh0gql-ffmpeg-3.4.4-man...
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
Moving /nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4/bin to /nix/store/n09w70ijxgdf49ggrqj3ajn0ccafyfwy-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/h77ka6q570sb97s9fksmnj91anhmq0fb-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
/nix/store/n09w70ijxgdf49ggrqj3ajn0ccafyfwy-ffmpeg-3.4.4-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

gzipping man pages under /nix/store/p1alrm9bp2a4bq44fd07mk9j40i30jkf-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/p1alrm9bp2a4bq44fd07mk9j40i30jkf-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/p1alrm9bp2a4bq44fd07mk9j40i30jkf-ffmpeg-3.4.4-man...
strip is /nix/store/hy39vplmzpwckvzxgyhr54dwz0mnfv2p-binutils-2.28.1/bin/strip
Moving /nix/store/4vh9hbzl9r9xw3bnj5fnh4s61r2qdx3g-ffmpeg-3.4.4/bin to /nix/store/raj0v6mmca1iyq7d829hc84fpra3m26h-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/4vh9hbzl9r9xw3bnj5fnh4s61r2qdx3g-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/4vh9hbzl9r9xw3bnj5fnh4s61r2qdx3g-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/h16s1hk4kj7kqrzwfa72fg6iyw3x6x83-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/4vh9hbzl9r9xw3bnj5fnh4s61r2qdx3g-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
/nix/store/raj0v6mmca1iyq7d829hc84fpra3m26h-ffmpeg-3.4.4-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

these derivations will be built:
  /nix/store/a8zvmmf8dbby1znq9cnw4492hkxjlirj-ffmpeg-3.4.4.drv
waiting for locks or build slots...
/nix/store/raj0v6mmca1iyq7d829hc84fpra3m26h-ffmpeg-3.4.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

gzipping man pages under /nix/store/dvaffxb23d0m6nmlyxnib6jfifyh0gql-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/dvaffxb23d0m6nmlyxnib6jfifyh0gql-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/dvaffxb23d0m6nmlyxnib6jfifyh0gql-ffmpeg-3.4.4-man...
strip is /nix/store/k8b9hqv58dd1z0j4ikak24ykndcm91s6-binutils-2.28.1/bin/strip
Moving /nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4/bin to /nix/store/n09w70ijxgdf49ggrqj3ajn0ccafyfwy-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/h77ka6q570sb97s9fksmnj91anhmq0fb-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/b6yvnayrav2klql3xjlkshjkacmjsmr4-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
/nix/store/n09w70ijxgdf49ggrqj3ajn0ccafyfwy-ffmpeg-3.4.4-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mat8913 @vcunat @GrahamcOfBorg