Hangups 0.4.5 #44425

aswan89 · 2018-08-03T21:17:56Z

Motivation for this change

Adds Google Hangouts terminal client to NixPkgs

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

dotlambda

Please add a prefix of pythonPackages. to the appropriate commit messages.
Also, the meta.maintainers field is required.

dotlambda · 2018-08-03T22:09:03Z

pkgs/top-level/python-packages.nix

@@ -2287,7 +2287,7 @@ in {
  });

  elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { };
-
+  


remove this whitespace change

dotlambda · 2018-08-03T22:11:16Z

@GrahamcOfBorg eval
@GrahamcOfBorg build python2.pkgs.readlike hangups

GrahamcOfBorg · 2018-08-03T22:12:00Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.readlike, hangups

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'hangups.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ffm3k068bcl77q6hwm9n7li89kppy6cj-python2.7-readlike-0.1.2
/nix/store/5srdvbhl9ah0fyzyrqh64dxkbbsl7cqj-hangups-0.4.5

GrahamcOfBorg · 2018-08-03T22:12:46Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.readlike, hangups

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'hangups.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
/nix/store/r5z8aykmq7zld4rw2h62xwrlmv7xkja8-python2.7-readlike-0.1.2
/nix/store/5nnd19f7h8mxx9392aj3krqf5da7jg5m-hangups-0.4.5

dotlambda · 2018-08-03T22:16:27Z

Ran 0 tests in 0.000s

Please provide an appropriate checkPhases or set doCheck = false with a comment saying why you're doing that.
Btw, it's very annoying to have to request the same changes again. Have a look at your previous PR. Also, please just keep this PR open and force push to your branch instead of opening a new one.

Mic92 · 2018-08-03T22:24:59Z

@GrahamcOfBorg eval

LnL7 · 2018-08-03T22:37:48Z

@GrahamcOfBorg eval

Mic92 · 2018-08-04T15:03:06Z

You might want to checkout interactive git-rebase, so you don't need to close and re-open pull requests for the same package.

aswan89 · 2018-08-07T17:30:35Z

Requested changes have been pushed.

dotlambda · 2018-08-07T22:12:49Z

@GrahamcOfBorg build python2.pkgs.readlike hangups

GrahamcOfBorg · 2018-08-07T22:13:46Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.readlike, hangups

Partial log (click to expand)

/build/hangups-0.4.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/68vddj0s4j7ll6d21kjsz8fp22ijqr1a-hangups-0.4.5
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/68vddj0s4j7ll6d21kjsz8fp22ijqr1a-hangups-0.4.5/lib  /nix/store/68vddj0s4j7ll6d21kjsz8fp22ijqr1a-hangups-0.4.5/bin
patching script interpreter paths in /nix/store/68vddj0s4j7ll6d21kjsz8fp22ijqr1a-hangups-0.4.5
checking for references to /build in /nix/store/68vddj0s4j7ll6d21kjsz8fp22ijqr1a-hangups-0.4.5...
wrapping `/nix/store/68vddj0s4j7ll6d21kjsz8fp22ijqr1a-hangups-0.4.5/bin/hangups'...
/nix/store/ffm3k068bcl77q6hwm9n7li89kppy6cj-python2.7-readlike-0.1.2
/nix/store/68vddj0s4j7ll6d21kjsz8fp22ijqr1a-hangups-0.4.5

GrahamcOfBorg · 2018-08-07T22:14:28Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.readlike, hangups

Partial log (click to expand)

/build/hangups-0.4.5
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/z7a04vhgyhhn7maqxlj07l1p4ns4aq0y-hangups-0.4.5
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z7a04vhgyhhn7maqxlj07l1p4ns4aq0y-hangups-0.4.5/lib  /nix/store/z7a04vhgyhhn7maqxlj07l1p4ns4aq0y-hangups-0.4.5/bin
patching script interpreter paths in /nix/store/z7a04vhgyhhn7maqxlj07l1p4ns4aq0y-hangups-0.4.5
checking for references to /build in /nix/store/z7a04vhgyhhn7maqxlj07l1p4ns4aq0y-hangups-0.4.5...
wrapping `/nix/store/z7a04vhgyhhn7maqxlj07l1p4ns4aq0y-hangups-0.4.5/bin/hangups'...
/nix/store/r5z8aykmq7zld4rw2h62xwrlmv7xkja8-python2.7-readlike-0.1.2
/nix/store/z7a04vhgyhhn7maqxlj07l1p4ns4aq0y-hangups-0.4.5

dotlambda · 2018-08-07T22:24:28Z

Ran 0 tests in 0.000s

aswan89 · 2018-08-23T20:37:43Z

The added dependencies have had their check phase disabled since the PyPi packages have no tests included.

dotlambda · 2018-08-31T13:05:11Z

pkgs/applications/networking/instant-messengers/hangups/default.nix

@@ -0,0 +1,53 @@
+{stdenv, python3, lib}:


Either stdenv or lib.

dotlambda · 2018-08-31T13:05:18Z

pkgs/development/python-modules/ReParser/default.nix

@@ -0,0 +1,23 @@
+{ stdenv, buildPythonPackage, fetchPypi, isPy3k, lib}:


Either stdenv or lib.

dotlambda · 2018-08-31T13:05:24Z

pkgs/development/python-modules/readlike/default.nix

@@ -0,0 +1,21 @@
+{ stdenv, buildPythonPackage, fetchPypi, lib }:


Either stdenv or lib.

dotlambda · 2018-08-31T13:06:35Z

pkgs/top-level/python-packages.nix

@@ -11845,6 +11845,10 @@ in {

  readme_renderer = callPackage ../development/python-modules/readme_renderer { };

+  readlike = callPackage ../development/python-modules/readlike { };
+
+  ReParser = callPackage ../development/python-modules/ReParser { };


Please use reparser, also for the directory name: #45822

dotlambda · 2018-08-31T13:10:05Z

Hangups seems to also be used as a library, e.g. by Home Assistant. So, it should be added to pythonPackages. What do you think?
This would mean we cannot override package versions, however we can probably just replace == by >= in postPatch.

aswan89 · 2018-08-31T13:20:57Z

I waffled on whether to include it as a package vs. as an application. My reading of the Nix python documentation made it sound like the primary reason for building as a package vs. an application was so it would build for both python 2 and python 3. Hangups isn't compatible with python 3 at all so I figured it would be easier to build it as an application vs. trying to disable it for python 2.

dotlambda · 2018-08-31T13:22:53Z

Well, if it is used using import ..., it should generally be added to pythonPackages.

aanderse · 2019-05-19T10:51:09Z

@aswan89 are you able to address the above comments and continue with this PR?

jonringer · 2019-12-20T17:29:02Z

bump

stale · 2020-06-17T18:09:34Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

jonringer · 2020-06-17T18:16:42Z

the user's fork was deleted, and no progress in a year.

closing

aswan89 requested a review from FRidh as a code owner August 3, 2018 21:17

GrahamcOfBorg added the 6.topic: python label Aug 3, 2018

dotlambda requested changes Aug 3, 2018

View reviewed changes

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 3, 2018

aswan89 added 3 commits August 9, 2018 13:16

pythonPackages.readlike: init at 0.1.2

d0f94db

pythonPackages.ReParser: init at 1.4.3

b497d33

hangups: init at 0.4.5

8c41349

dotlambda requested changes Aug 31, 2018

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 17, 2020

jonringer closed this Jun 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hangups 0.4.5 #44425

Hangups 0.4.5 #44425

aswan89 commented Aug 3, 2018

dotlambda left a comment

dotlambda Aug 3, 2018

dotlambda commented Aug 3, 2018

GrahamcOfBorg commented Aug 3, 2018

GrahamcOfBorg commented Aug 3, 2018

dotlambda commented Aug 3, 2018

Mic92 commented Aug 3, 2018

LnL7 commented Aug 3, 2018

Mic92 commented Aug 4, 2018 •

edited

aswan89 commented Aug 7, 2018

dotlambda commented Aug 7, 2018

GrahamcOfBorg commented Aug 7, 2018

GrahamcOfBorg commented Aug 7, 2018

dotlambda commented Aug 7, 2018

aswan89 commented Aug 23, 2018

dotlambda Aug 31, 2018

dotlambda Aug 31, 2018

dotlambda Aug 31, 2018

dotlambda Aug 31, 2018

dotlambda commented Aug 31, 2018 •

edited

aswan89 commented Aug 31, 2018

dotlambda commented Aug 31, 2018

aanderse commented May 19, 2019

jonringer commented Dec 20, 2019

stale bot commented Jun 17, 2020

jonringer commented Jun 17, 2020

		@@ -2287,7 +2287,7 @@ in {
		});

		elasticsearch-curator = callPackage ../development/python-modules/elasticsearch-curator { };

		@@ -0,0 +1,23 @@
		{ stdenv, buildPythonPackage, fetchPypi, isPy3k, lib}:

		@@ -0,0 +1,21 @@
		{ stdenv, buildPythonPackage, fetchPypi, lib }:

Hangups 0.4.5 #44425

Hangups 0.4.5 #44425

Conversation

aswan89 commented Aug 3, 2018

Motivation for this change

Things done

dotlambda left a comment

Choose a reason for hiding this comment

dotlambda Aug 3, 2018

Choose a reason for hiding this comment

dotlambda commented Aug 3, 2018

GrahamcOfBorg commented Aug 3, 2018

GrahamcOfBorg commented Aug 3, 2018

dotlambda commented Aug 3, 2018

Mic92 commented Aug 3, 2018

LnL7 commented Aug 3, 2018

Mic92 commented Aug 4, 2018 • edited

aswan89 commented Aug 7, 2018

dotlambda commented Aug 7, 2018

GrahamcOfBorg commented Aug 7, 2018

GrahamcOfBorg commented Aug 7, 2018

dotlambda commented Aug 7, 2018

aswan89 commented Aug 23, 2018

dotlambda Aug 31, 2018

Choose a reason for hiding this comment

dotlambda Aug 31, 2018

Choose a reason for hiding this comment

dotlambda Aug 31, 2018

Choose a reason for hiding this comment

dotlambda Aug 31, 2018

Choose a reason for hiding this comment

dotlambda commented Aug 31, 2018 • edited

aswan89 commented Aug 31, 2018

dotlambda commented Aug 31, 2018

aanderse commented May 19, 2019

jonringer commented Dec 20, 2019

stale bot commented Jun 17, 2020

jonringer commented Jun 17, 2020

Mic92 commented Aug 4, 2018 •

edited

dotlambda commented Aug 31, 2018 •

edited