Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prototypejs: Init at 1.7.3.0 #44428

Merged
merged 1 commit into from Aug 5, 2018
Merged

prototypejs: Init at 1.7.3.0 #44428

merged 1 commit into from Aug 5, 2018

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Aug 3, 2018

Motivation for this change

I'm currently packaging FusionDirectory, and this is a dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member Author

dasJ commented Aug 3, 2018

Failing check unrelated

@Mic92
Copy link
Member

Mic92 commented Aug 3, 2018

@GrahamcOfBorg eval

1 similar comment
@LnL7
Copy link
Member

LnL7 commented Aug 3, 2018

@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented Aug 4, 2018

Since you're not really building but just downloading a single file here, an alternative is to use fetchurl as a derivation directly:

{ stdenv, fetchurl, ... }:
let
  version = "1.7.3.0";
in
  fetchurl {
    name = "prototypejs-${version}.js";
    url = "https://ajax.googleapis.com/ajax/libs/prototype/${version}/prototype.js";
    sha256 = "...";
    meta = with stdenv.lib; { ... };
  }

Building this puts the downloaded file directly in the nix store under name. Just showing you this so you know about it. The way you did it is fine as well.

@dasJ
Copy link
Member Author

dasJ commented Aug 5, 2018

@xeji Thanks for that great hint! I rewrote and rebased it

@xeji
Copy link
Contributor

xeji commented Aug 5, 2018

@GrahamcOfBorg build prototypejs

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: prototypejs

Partial log (click to expand)

these derivations will be built:
  /nix/store/ykky7r1v1wxjgfa8zldz10kyvcr1h380-prototype-1.7.3.0.js.drv
building '/nix/store/ykky7r1v1wxjgfa8zldz10kyvcr1h380-prototype-1.7.3.0.js.drv'...

trying https://ajax.googleapis.com/ajax/libs/prototype/1.7.3.0/prototype.js
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  195k    0  195k    0     0   661k      0 --:--:-- --:--:-- --:--:--  661k
/nix/store/i91h5jak998m7kdbjbpfjvv7z4mwpxfa-prototype-1.7.3.0.js

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: prototypejs

Partial log (click to expand)

these derivations will be built:
  /nix/store/195i19192a8jxwaza761q16q1pqzxihr-prototype-1.7.3.0.js.drv
building '/nix/store/195i19192a8jxwaza761q16q1pqzxihr-prototype-1.7.3.0.js.drv'...

trying https://ajax.googleapis.com/ajax/libs/prototype/1.7.3.0/prototype.js
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  195k    0  195k    0     0  3198k      0 --:--:-- --:--:-- --:--:-- 3198k
/nix/store/i91h5jak998m7kdbjbpfjvv7z4mwpxfa-prototype-1.7.3.0.js

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: prototypejs

Partial log (click to expand)

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 42416  100 42416    0     0  42416      0  0:00:01 --:--:--  0:00:01  201k

building path(s) ‘/nix/store/i91h5jak998m7kdbjbpfjvv7z4mwpxfa-prototype-1.7.3.0.js’

trying https://ajax.googleapis.com/ajax/libs/prototype/1.7.3.0/prototype.js
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  195k    0  195k    0     0  10.5M      0 --:--:-- --:--:-- --:--:-- 10.5M
/nix/store/i91h5jak998m7kdbjbpfjvv7z4mwpxfa-prototype-1.7.3.0.js

@xeji
Copy link
Contributor

xeji commented Aug 5, 2018

Thank you.

@xeji xeji merged commit 2da0208 into NixOS:master Aug 5, 2018
@dasJ dasJ deleted the prototype branch August 6, 2018 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasJ @Mic92 @LnL7 @xeji @GrahamcOfBorg