Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs package updates #43609

Merged
merged 2 commits into from Jul 17, 2018
Merged

Emacs package updates #43609

merged 2 commits into from Jul 17, 2018

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Jul 16, 2018

Motivation

All package sets are simultaneously updated to accommodate changes to
package-build. Due to new restrictions in package-build, all packages using
melpaBuild must now provide a recipe file, even those packages which are not
included in upstream MELPA.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ttuegel
emacsPackagesNg: 2018-07-15 update
d3cea48 
All package sets are simultaneously updated to accommodate changes to
package-build. Due to new restrictions in package-build, all packages using
`melpaBuild` must now provide a recipe file, even those packages which are not
included in upstream MELPA.
@ttuegel ttuegel merged commit 9cfbef8 into NixOS:master Jul 17, 2018
@ttuegel ttuegel deleted the emacs-packages-2018-07-14 branch July 17, 2018 22:54
@periklis
Copy link
Contributor

@ttuegel with the latest update i get the following error:

builder for '/nix/store/ail1ns5x2rbmp7nd2xjpg0b005j8m3rr-emacs-term-plus-20170508.1717.drv' failed with exit code 255; last 8 log lines:
  unpacking sources
  unpacking source archive /nix/store/jnwha91gkpdpf917k8y0im8jc27hsfmk-source
  source root is source
  patching sources
  configuring
  no configure script, doing nothing
  building
  Recipe 'term-plus' contains mismatched package name 'term+'
cannot build derivation '/nix/store/r9w1xk01bp5mz1risxdaq9y8qwpvsblm-emacs-with-packages-26.1.drv': 1 dependencies couldn't be built

@ttuegel ttuegel mentioned this pull request Jul 21, 2018
Closed
ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Jul 23, 2018
@ttuegel
melpaBuild: use Emacs package names to satisfy package-build
7131e35 
package-build expects the recipe file name to match the Emacs package
name. `melpaBuild` takes an extra argument `ename` for the Emacs package
name (default: `pname`, the Nix package name) which is used to name the recipe
file.

Fixes: NixOS#43893
See also: NixOS#43609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis adisbladis is a code owner

Assignees
No one assigned
Labels
6.topic: emacs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ttuegel @periklis @matthewbauer @GrahamcOfBorg