mpv: build and install macOS App Bundle #43612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
| mkdir -p $out/Applications | ||
| cp -r build/mpv.app $out/Applications | ||
| wrapProgram $out/Applications/mpv.app/Contents/MacOS/mpv \ | ||
| --add-flags "--scripts=${concatStringsSep "," scripts}" \ |
There was a problem hiding this comment.
It would be nice to refactor this to avoid duplication. In these cases it may make sense to just do:
mkdir -p $out/Applications
cp -r build/mpv.app $out/Applications
rm $out/Applications/mpv.app/Contents/MacOS/mpv
ln -s $out/bin/mpv $out/Applications/mpv.app/Contents/MacOS/mpv
There was a problem hiding this comment.
I tested this and mpv.app just quits whenever I try to open it, I don't know too much about macOS so I didn't manage to find any error messages related to this. The only method I know of was checking Console.app, but that doesn't show anything related.
At the very least I could move all the wrapProgram flags into a variable to avoid duplication that way.
Enzime
force-pushed
the
add/mpv-app-bundle
branch
from
d0609b4
to
80316cd
Compare
|
@GrahamcOfBorg build mpv edit: lol |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: enzime Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: enzime Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: enzime Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mpv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mpv Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mpv Partial log (click to expand)
|
LnL7
approved these changes
Jul 21, 2018
Enzime
force-pushed
the
add/mpv-app-bundle
branch
from
80316cd
to
0351e9e
Compare
|
@GrahamcOfBorg build mpv |
|
Failure on x86_64-darwin (full log) Attempted: mpv Partial log (click to expand)
|
|
Hmm, this worked before. |
|
Success on x86_64-linux (full log) Attempted: mpv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mpv Partial log (click to expand)
|
matthewbauer
approved these changes
Aug 2, 2018
|
I am able to build it locally. |
|
@matthewbauer are you building this with mpv 0.29.0? |
Enzime
force-pushed
the
add/mpv-app-bundle
branch
from
0351e9e
to
f8fb13e
Compare
|
@GrahamcOfBorg build mpv |
|
Success on x86_64-linux (full log) Attempted: mpv Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: mpv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mpv Partial log (click to expand)
|
LnL7
approved these changes
Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)