treewide: simplify some dependency cycles #43627

oxij · 2018-07-16T17:24:21Z

Yet another followup to #39464.

FRidh · 2018-07-16T18:36:31Z

pkgs/development/python-modules/hypothesis/default.nix

  propagatedBuildInputs = [ attrs coverage ] ++ lib.optional (!isPy3k) [ enum34 ];

+  checkInputs = [ pytest pytest_xdist flaky mock ];


unnecessary change

oxij · 2018-07-16T19:05:21Z

@FRidh

unnecessary change

It's necessary for satisfying my OCD of grouping related things together.

orivej · 2018-07-16T20:28:50Z

@GrahamcOfBorg eval

GrahamcOfBorg · 2018-07-16T20:53:30Z

Success on x86_64-linux (full log)

Attempted: glib, libffi

Partial log (click to expand)

these paths will be fetched (0.02 MiB download, 0.04 MiB unpacked):
  /nix/store/9659ffz01appc8k4fw4bjdk4jckgl6bf-libffi-3.2.1
copying path '/nix/store/9659ffz01appc8k4fw4bjdk4jckgl6bf-libffi-3.2.1' from 'https://cache.nixos.org'...
/nix/store/4fabv5pnkp0gd4l3k416v9k89vk3wi74-glib-2.56.0
/nix/store/9659ffz01appc8k4fw4bjdk4jckgl6bf-libffi-3.2.1

orivej

/cc @vcunat @domenkozar
glib-tested was a part of release.nix until it was removed in c21f936, probably due to mysterious Nix failures on Hydra. Its build has not been failing since then.

orivej · 2018-07-16T20:56:11Z

pkgs/top-level/all-packages.nix

-    doCheck = true;
-    libffi = libffi.override { doCheck = true; };
+    # dependency cycle
+    libffi = libffi.override { doCheck = false; };


Is this override necessary? I can instantiate glib without it.

GrahamcOfBorg · 2018-07-16T21:12:59Z

Success on aarch64-linux (full log)

Attempted: glib, libffi

Partial log (click to expand)

patching script interpreter paths in /nix/store/p7s70nlz0sr296kx393pr4mxfif8snj3-glib-2.56.0-dev
/nix/store/p7s70nlz0sr296kx393pr4mxfif8snj3-glib-2.56.0-dev/bin/glib-gettextize: interpreter directive changed from " /bin/sh" to "/nix/store/xlv8nwq2cbxm2yancb3yk3424ziyb91q-bash-4.4-p23/bin/sh"
/nix/store/p7s70nlz0sr296kx393pr4mxfif8snj3-glib-2.56.0-dev/bin/gdbus-codegen: interpreter directive changed from "/usr/bin/env /nix/store/85f7frkl9amv34wsblmasklhh0s38xra-python-2.7.15/bin/python" to "/nix/store/85f7frkl9amv34wsblmasklhh0s38xra-python-2.7.15/bin/python"
checking for references to /build in /nix/store/p7s70nlz0sr296kx393pr4mxfif8snj3-glib-2.56.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/6703j1rsbns97n50r60rh4cmlx2g2waa-glib-2.56.0-devdoc
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/6703j1rsbns97n50r60rh4cmlx2g2waa-glib-2.56.0-devdoc
checking for references to /build in /nix/store/6703j1rsbns97n50r60rh4cmlx2g2waa-glib-2.56.0-devdoc...
/nix/store/vs1c6v8f6c1vn0jjb5lq0skcgg41fz7s-glib-2.56.0
/nix/store/s2ppffrlrbv71fmczm08xyghkzk699as-libffi-3.2.1

oxij · 2018-07-16T22:44:34Z

Is this override necessary? I can instantiate `glib` without it.

Oops, right, that's because `glib` has `doCheck` set to `true` by default in my branch and I have not upstreamed those patches yet. I tried to split stuff into bite-sized pieces, but failed in this instance. Then, the logical way to proceed is to close this PR and to postpone this discussion till I get those patches ready then.

…ycle fix

oxij · 2018-07-16T23:20:36Z

On the second though, nothing prevents me from removing only that part from here too. Updated. The glib things will go into a separate PR.

GrahamcOfBorg · 2018-07-16T23:31:29Z

Success on aarch64-linux (full log)

Attempted: libffi

Partial log (click to expand)

/nix/store/s2ppffrlrbv71fmczm08xyghkzk699as-libffi-3.2.1

GrahamcOfBorg · 2018-07-16T23:31:56Z

Success on x86_64-linux (full log)

Attempted: libffi

Partial log (click to expand)

these paths will be fetched (0.02 MiB download, 0.04 MiB unpacked):
  /nix/store/9659ffz01appc8k4fw4bjdk4jckgl6bf-libffi-3.2.1
copying path '/nix/store/9659ffz01appc8k4fw4bjdk4jckgl6bf-libffi-3.2.1' from 'https://cache.nixos.org'...
/nix/store/9659ffz01appc8k4fw4bjdk4jckgl6bf-libffi-3.2.1

oxij · 2018-07-17T23:31:47Z

@GrahamcOfBorg build python2Packages.pytest python2Packages.hypothesis

GrahamcOfBorg · 2018-07-17T23:32:21Z

Success on x86_64-linux (full log)

Attempted: python2Packages.pytest, python2Packages.hypothesis

Partial log (click to expand)

these paths will be fetched (0.26 MiB download, 1.80 MiB unpacked):
  /nix/store/23i6m85rr562rla0xgvv8lz3ykjny3fw-python2.7-hypothesis-3.45.2
copying path '/nix/store/23i6m85rr562rla0xgvv8lz3ykjny3fw-python2.7-hypothesis-3.45.2' from 'https://cache.nixos.org'...
/nix/store/xqpifc0fr195m5xw8q59zg1d9ci4z515-python2.7-pytest-3.6.2
/nix/store/23i6m85rr562rla0xgvv8lz3ykjny3fw-python2.7-hypothesis-3.45.2

oxij · 2018-07-18T00:03:51Z

Ping. Anything holding this now?

GrahamcOfBorg · 2018-07-18T00:33:06Z

Success on aarch64-linux (full log)

Attempted: python2Packages.pytest, python2Packages.hypothesis

Partial log (click to expand)

test_can_generate_interval_endpoints[-1.0-0.0] passed 1 out of the required 1 times. Success!
test_can_generate_interval_endpoints[-2.22507385851e-308-2.22507385851e-308] passed 1 out of the required 1 times. Success!
test_half_bounded_generates_endpoint passed 1 out of the required 1 times. Success!
test_can_find_unique_lists_of_non_set_order passed 1 out of the required 1 times. Success!

===End Flaky Test Report===

================== 1856 passed, 3 skipped in 1817.34 seconds ===================
/nix/store/vzj89gvgd3b385qhvzyxh4x5yi3nwil5-python2.7-pytest-3.6.2
/nix/store/28k2apc0nlaxn62c3v8a8yc8acliia05-python2.7-hypothesis-3.45.2

LnL7 · 2018-07-21T20:52:11Z

FYI. This broke the darwin stdenv.

matthewbauer · 2018-07-21T21:16:36Z

Ok. Unless there is an alternative fix available we can just do doCheck ? !stdenv.isDarwin, correct? That would restore old behavior until we can figure out what is going on.

LnL7 · 2018-07-21T21:22:40Z

Yeah, I'm testing to see if there are any other problems.

oxij requested a review from FRidh as a code owner July 16, 2018 17:24

matthewbauer approved these changes Jul 16, 2018

View reviewed changes

FRidh reviewed Jul 16, 2018

View reviewed changes

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin-stdenv 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ labels Jul 16, 2018

orivej reviewed Jul 16, 2018

View reviewed changes

oxij added 2 commits July 16, 2018 23:16

libffi: simplify using checkInputs

2badf9a

pythonPackges.hypothesis, pythonPackages.pytest: simpify dependency c…

acbee90

…ycle fix

oxij force-pushed the tree/simplify-depcycles branch from 9bd0085 to acbee90 Compare July 16, 2018 23:17

oxij mentioned this pull request Jul 17, 2018

glib: use tested version when doCheckByDefault is set #43702

Merged

matthewbauer merged commit c0beb48 into NixOS:staging Jul 18, 2018

oxij deleted the tree/simplify-depcycles branch November 18, 2018 08:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

treewide: simplify some dependency cycles #43627

treewide: simplify some dependency cycles #43627

oxij commented Jul 16, 2018

FRidh Jul 16, 2018

oxij commented Jul 16, 2018 via email

orivej commented Jul 16, 2018

GrahamcOfBorg commented Jul 16, 2018

orivej left a comment

orivej Jul 16, 2018

GrahamcOfBorg commented Jul 16, 2018

oxij commented Jul 16, 2018 via email

oxij commented Jul 16, 2018 via email

GrahamcOfBorg commented Jul 16, 2018

GrahamcOfBorg commented Jul 16, 2018

oxij commented Jul 17, 2018

GrahamcOfBorg commented Jul 17, 2018

oxij commented Jul 18, 2018 via email

GrahamcOfBorg commented Jul 18, 2018

LnL7 commented Jul 21, 2018

matthewbauer commented Jul 21, 2018

LnL7 commented Jul 21, 2018

		propagatedBuildInputs = [ attrs coverage ] ++ lib.optional (!isPy3k) [ enum34 ];

		checkInputs = [ pytest pytest_xdist flaky mock ];

treewide: simplify some dependency cycles #43627

treewide: simplify some dependency cycles #43627

Conversation

oxij commented Jul 16, 2018

FRidh Jul 16, 2018

Choose a reason for hiding this comment

oxij commented Jul 16, 2018 via email

orivej commented Jul 16, 2018

GrahamcOfBorg commented Jul 16, 2018

orivej left a comment

Choose a reason for hiding this comment

orivej Jul 16, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Jul 16, 2018

oxij commented Jul 16, 2018 via email

oxij commented Jul 16, 2018 via email

GrahamcOfBorg commented Jul 16, 2018

GrahamcOfBorg commented Jul 16, 2018

oxij commented Jul 17, 2018

GrahamcOfBorg commented Jul 17, 2018

oxij commented Jul 18, 2018 via email

GrahamcOfBorg commented Jul 18, 2018

LnL7 commented Jul 21, 2018

matthewbauer commented Jul 21, 2018

LnL7 commented Jul 21, 2018