nixos/display-managers: fix loading of module-x11-publish #43610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Aug 2, 2018
| ${config.hardware.pulseaudio.package.out}/bin/pactl load-module module-x11-publish "display=$DISPLAY" | ||
| # Publish access credentials in the root window if supported by PulseAudio. | ||
| ${optionalString (config.hardware.pulseaudio.package == pkgs.pulseaudioFull) | ||
| "${config.hardware.pulseaudio.package.out}/bin/pactl load-module module-x11-publish 'display=$DISPLAY'" |
There was a problem hiding this comment.
I think using || true is a better solution, because this here won't work when the user has an even slighly modified pulseaudio, because then the derivations won't match.
There was a problem hiding this comment.
Yes, that is a better way. Thank you.
There was a problem hiding this comment.
Actually, wait. This doesn't get rid of the error message. What about using pulseaudio --dump-modules to check if module-x11-publish is available?
jfrankenau
force-pushed
the
fix-pulse-module-x11-publish
branch
2 times, most recently
from
932c1d9
to
900957c
Compare
module-x11-publish is only provided by the pulseaudioFull package.
jfrankenau
force-pushed
the
fix-pulse-module-x11-publish
branch
from
900957c
to
b7ce7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #11970
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)