Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.parsy: init at 1.2.0 #43631

Merged
merged 2 commits into from Jul 16, 2018
Merged

pythonPackages.parsy: init at 1.2.0 #43631

merged 2 commits into from Jul 16, 2018

Conversation

milibopp
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@milibopp milibopp requested a review from FRidh as a code owner July 16, 2018 18:37
@FRidh
Copy link
Member

FRidh commented Jul 16, 2018

@GrahamcOfBorg build pythonPackages.parsy python3Packages.parsy

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.parsy

The following builds were skipped because they don't evaluate on x86_64-linux: pythonPackages.parsy

Partial log (click to expand)

platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /tmp/nix-build-python3.6-parsy-1.2.0.drv-0/parsy-1.2.0, inifile:
collected 67 items

test/test_parsy.py ..................................................... [ 79%]
.........                                                                [ 92%]
test/test_sexpr.py .....                                                 [100%]

========================== 67 passed in 0.14 seconds ===========================
/nix/store/lp8vx072imymjfhr2nr8kc2xijihwi4c-python3.6-parsy-1.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.parsy

The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.parsy

Partial log (click to expand)

platform darwin -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /private/tmp/nix-build-python3.6-parsy-1.2.0.drv-0/parsy-1.2.0, inifile:
collected 67 items

test/test_parsy.py ..................................................... [ 79%]
.........                                                                [ 92%]
test/test_sexpr.py .....                                                 [100%]

========================== 67 passed in 0.26 seconds ===========================
/nix/store/jyc7gbh3npf7kr8vpjdc2rsrg42rr7y3-python3.6-parsy-1.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.parsy

The following builds were skipped because they don't evaluate on aarch64-linux: pythonPackages.parsy

Partial log (click to expand)

platform linux -- Python 3.6.5, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/parsy-1.2.0, inifile:
collected 67 items

test/test_parsy.py ..................................................... [ 79%]
.........                                                                [ 92%]
test/test_sexpr.py .....                                                 [100%]

========================== 67 passed in 0.57 seconds ===========================
/nix/store/pzd3a78nj4ranz9l1jicf8l5ym5z1l7p-python3.6-parsy-1.2.0

FRidh
FRidh requested changes Jul 16, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a small change is needed.

By the way, interesting library. A while ago I had to write a parser and used lark for it. It took some time for me to grasp how it worked, but after that it was pleasant to work with.

pkgs/development/python-modules/parsy/default.nix Outdated
@@ -0,0 +1,26 @@
{ lib, pkgs, buildPythonPackage, fetchPypi, pythonOlder, pytest }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no pkgs

dotlambda
dotlambda reviewed Jul 16, 2018
View reviewed changes
pkgs/development/python-modules/parsy/default.nix Outdated
disabled = pythonOlder "3.4";

meta = with lib; {
homepage = "https://github.com/python-parsy/parsy";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no quotes

@milibopp
Copy link
Contributor Author

milibopp commented Jul 16, 2018 •
edited

@FRidh just made the change you requested. And, yes, this type of library makes implementing a parser much quicker and less error-prone. :)

@dotlambda thanks for the tip, I was not aware I could just leave out the quotes like that.

@dotlambda dotlambda merged commit ac7d8d2 into NixOS:master Jul 16, 2018
@milibopp milibopp deleted the parsy/init branch July 16, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@milibopp @FRidh @GrahamcOfBorg @dotlambda @Janik-Haag