Closely related: in the past few days I was thinking a bit about the nixos vs. nixpkgs split we have on Hydra. I think it complicates the situation of staging-next (formerly of staging), because the decision whether to merge needs to take into account all: nixos tests (linux) and packages including darwin ones. Moreover, the nixos+nixpkgs split makes spotting "regressions against master" more difficult – and that seems important as aarch64 and darwin have relatively high failing counts on Hydra (they do so even on 18.03). I think the main blocker of comparisons is the nixpkgs. nesting in release-combined.nix.

in the past few days I was thinking a bit about the nixos vs. nixpkgs split we have on Hydra.

I think it may be worthwhile to add several NixOS tests here as well, but that's harder due to the split.

Also, I think we should test basic cross support cc @Ericson2314

Yes, I imagine to have all we care for aggregated in one release.nix, for all platforms (which can be restricted via a parameter like now – useful for platform-specific channels/jobsets). And a corresponding release-small.nix for "important" things (something like this PR).

Current staging related jobs:

• https://hydra.nixos.org/jobset/nixos/staging-small
• https://hydra.nixos.org/jobset/nixos/staging (unused)
• https://hydra.nixos.org/jobset/nixpkgs/staging
• https://hydra.nixos.org/jobset/nixpkgs/staging-next

To avoid 6c72782#commitcomment-29793883 in the future we might include some nixos tests?

We should also have some cross tests to ensure that still works (NixOS/ofborg#355)

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/new-merge-policy-for-an-always-green-hydra/8889/24

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/fixing-the-staging-staging-next-workflow/9643/2

I marked this as stale due to inactivity. → More info

What's the status on this?

This looks like a good set to me; we can figure out further things to add later.

I never pursued this further because I cannot change jobs on Hydra. What needs to be done now is update this PR with the correct sets, merge it, and then create/update a job on Hydra. @vcunat can probably help with this.