New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urbit: 0.4.5 -> 0.6.0 #45041
urbit: 0.4.5 -> 0.6.0 #45041
Conversation
@GrahamcOfBorg build urbit |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: urbit Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: urbit Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: urbit Partial log (click to expand)
|
Great first contribution, I couldn't find a single thing to complain about 😄 Keep up the good work! |
I just noticed that this PR was based on
I'll fix this for you, no big deal. I should have paid more attention before merging. Just remember it next time :) |
Thanks for letting me know, and thanks for merging this!
I did try to rebase onto master but there were a ton of conflicts to resolve and I wasn’t sure what to do. Rebasing to release-18.03 worked without a conflict.
Sorry I should have explained, but honestly I didn’t expect this to be merged so quickly :)
… On Aug 15, 2018, at 04:42, Timo Kaufmann ***@***.***> wrote:
I just noticed that this PR was based on release-18.03. It should have been based on master.
release-18.03 is a release support branch. Only minor package updates and bugfixes should be pushed there. master is the "rolling release" branch from which the next release will be cut.
I'll fix this for you, no big deal. I should have paid more attention before merging. Just remember it next time :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
For now I have just reverted the commit on 18.03. I wouldn't expect conflicts with master, but if you say they're there I guess I'm expecting wrong. It would be easiest for me if you would open a new PR with the updated based on master (ping me on that one). Otherwise I'll do it myself when I have the time. |
@timokau maybe this message slipped under the cracks earlier today
Current master has 0.6.0 already @bsima was it your intention to backport 0.6.0 to 18.03? |
@bsima was it your intent to backport 0.6.0 to 18.03?
No that was not my intent. I just didn't realize that urbit was already bumped
to 0.6.0 in master, sorry! This PR can be ignored.
Although if backporting is an option, I would volunteer to do it if someone can
point me to docs on what the process is. I haven't seen docs on this in the
parts of the manual that I've read.
|
@samueldr oh yeah I missed that, thanks for repeating it here. @bsima basically for backporting the rule number 1 is to not break anything. The releases should be stable. So the api should not have any backwards incompatible changes and you should be reasonable sure to not break any reverse dependencies. |
With semver a good rule of thumb is to backport only patch releases. Of course that goes out of the window with |
Okay, then I'll leave this as it is. For the record, urbit-0.6.0 does work on
NixOS 18.03 (I'm running it now), so if anyone wants to they can build it from
one of the nix expressions on master or my branch in this PR.
|
Yes, the point of the release branches is just that users can run their system in everyday use and make security updates without worrying about breaking their system or having backwards incompatible changes in their software :) If you want the latest software (breakage included), you can change to the |
Anyways, thank you for upstreaming your efforts, I hope this will be one PR of many :) |
Motivation for this change
Updated to latest released version, verified working with the latest network breach.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)