buku: 3.7 -> 3.8 #45033

infinisil · 2018-08-14T17:52:47Z

Motivation for this change

A self-hosted http server, bukuserver, that exposes core functionality

browsable frontend on a local webhost server

flask default cli interface is used instead custom one

handle not only api but also html request

statistic page

CRUD on bookmark

eplaces the earlier api module

Import complete folder hierarchy as tags during auto-import

Merge tags on import even if bookmark URL exists

Orgfile import/export

Show bookmarks to be deleted before deletion

Merge tags during import if bookmark exists

Escape regex metachars in regex input

The new server component requires a bunch of new packages.

Closure size diff: 116MB -> 156MB, due to the new server component

Ping @jfrankenau @dotlambda

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

infinisil · 2018-08-14T17:53:35Z

pkgs/development/python-modules/dominate/default.nix

+    sha256 = "0s9s9j9xmhkzw7apqx170fyvc0f800fd4a5jfn8xvj9k6vryd32b";
+  };
+
+  doCheck = false;


Checks fail with this error for python3 only: https://gist.github.com/Infinisil/5d5d425d9b1d9eceed30ca4546382900#file-error-log-L46

GrahamcOfBorg · 2018-08-14T18:05:21Z

Success on x86_64-linux (full log)

Attempted: buku

Partial log (click to expand)

   # es,est,tes,test

similar tags:

1. es
2. est
3. news
4. tes

/nix/store/xlpj3qlqqif1mjvrkspq92w469710m2r-buku-3.8

GrahamcOfBorg · 2018-08-14T18:05:34Z

Success on aarch64-linux (full log)

Attempted: buku

Partial log (click to expand)

   # es,est,tes,test

similar tags:

1. es
2. est
3. news
4. tes

/nix/store/fw5m1svsqcgfqncn8p1xdyfiq4zrb383-buku-3.8

Mic92 · 2018-08-15T17:08:35Z

pkgs/top-level/python-packages.nix

@@ -5391,6 +5397,8 @@ in {

  flask_oauthlib = callPackage ../development/python-modules/flask-oauthlib { };

+  flask_paginate = callPackage ../development/python-modules/flask-paginate { };


I would use hyphens, especially if the project itself also uses hyphens in the name.

I think it's somewhat of a policy to prefer _ over - in nixpkgs, because using whatever the package is using gets confusing fast ("Why does foo_bar not exist, oh right it's foo-bar", "Why does bar-foo not exist, oh right it's bar_foo").

infinisil · 2018-08-15T22:38:25Z

pkgs/applications/misc/buku/default.nix

+    flask_api
+    flask_bootstrap
+    flask_paginate
+    flask_wtf


@Mic92 Also look at these deps here, would be weird for some of them to have a "-"

There are many counter example also in python packages and also for flask. I am not sure how consistent this was done for all flask packages, but it looks a bit messy, if the directory contains a hyphen as well as the upstream name, but we use sometimes hyphens and sometimes underscores.

infinisil · 2018-08-17T22:51:46Z

@Mic92 I fixed the package attributes

GrahamcOfBorg · 2018-08-17T23:05:16Z

Success on aarch64-linux (full log)

Attempted: buku

Partial log (click to expand)

   # es,est,tes,test

similar tags:

1. es
2. est
3. news
4. tes

/nix/store/l8qv8f44ipsbg7vpfsbyvzj4229dhywq-buku-3.8

GrahamcOfBorg · 2018-08-17T23:06:22Z

Success on x86_64-linux (full log)

Attempted: buku

Partial log (click to expand)

   # es,est,tes,test

similar tags:

1. es
2. est
3. news
4. tes

/nix/store/x369i7rdaqhxkh36h7a0q7lclkrdmz3z-buku-3.8

infinisil · 2018-08-19T21:56:16Z

@GrahamcOfBorg build buku

GrahamcOfBorg · 2018-08-19T21:56:49Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: buku

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-19T21:58:04Z

Success on aarch64-linux (full log)

Attempted: buku

Partial log (click to expand)

   # es,est,tes,test

similar tags:

1. es
2. est
3. news
4. tes

/nix/store/l8qv8f44ipsbg7vpfsbyvzj4229dhywq-buku-3.8

GrahamcOfBorg · 2018-08-19T21:58:05Z

Success on x86_64-linux (full log)

Attempted: buku

Partial log (click to expand)

   # es,est,tes,test

similar tags:

1. es
2. est
3. news
4. tes

/nix/store/x369i7rdaqhxkh36h7a0q7lclkrdmz3z-buku-3.8

infinisil · 2018-08-19T22:15:52Z

pkgs/development/python-modules/dominate/default.nix

+    sha256 = "0s9s9j9xmhkzw7apqx170fyvc0f800fd4a5jfn8xvj9k6vryd32b";
+  };
+
+  doCheck = !isPy3k;


Changed this to reflect that tests only fail with python 3, gist of the error still here: https://gist.github.com/Infinisil/5d5d425d9b1d9eceed30ca4546382900#file-error-log-L46

GrahamcOfBorg · 2018-08-19T22:30:37Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: buku

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-19T22:30:51Z

Success on aarch64-linux (full log)

Attempted: buku

Partial log (click to expand)

/nix/store/l8qv8f44ipsbg7vpfsbyvzj4229dhywq-buku-3.8

GrahamcOfBorg · 2018-08-19T22:39:15Z

Success on x86_64-linux (full log)

Attempted: buku

Partial log (click to expand)

/nix/store/x369i7rdaqhxkh36h7a0q7lclkrdmz3z-buku-3.8

infinisil requested a review from FRidh as a code owner August 14, 2018 17:52

infinisil commented Aug 14, 2018

View reviewed changes

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Aug 14, 2018

Mic92 reviewed Aug 15, 2018

View reviewed changes

infinisil commented Aug 15, 2018

View reviewed changes

infinisil force-pushed the update/buku branch from c121465 to 2d9ec01 Compare August 17, 2018 22:48

infinisil added 6 commits August 20, 2018 00:14

pythonPackages.dominate: init at 2.3.1

b2b9e68

pythonPackages.visitor: init at 0.1.3

28d7d7c

pythonPackages.flask-bootstrap: init at 3.3.7.1

4433f40

pythonPackages.flask-api: init at 1.0

f40c61c

pythonPackages.flask-paginate: init at 0.5.1

01bbc71

buku: 3.7 -> 3.8

dce1332

infinisil force-pushed the update/buku branch from 2d9ec01 to dce1332 Compare August 19, 2018 22:15

infinisil commented Aug 19, 2018

View reviewed changes

Mic92 merged commit f520d7c into NixOS:master Aug 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buku: 3.7 -> 3.8 #45033

buku: 3.7 -> 3.8 #45033

infinisil commented Aug 14, 2018

infinisil Aug 14, 2018

GrahamcOfBorg commented Aug 14, 2018

GrahamcOfBorg commented Aug 14, 2018

Mic92 Aug 15, 2018

infinisil Aug 15, 2018

infinisil Aug 15, 2018

Mic92 Aug 16, 2018 •

edited

infinisil commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

infinisil commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

infinisil Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

		@@ -5391,6 +5397,8 @@ in {

		flask_oauthlib = callPackage ../development/python-modules/flask-oauthlib { };

		flask_paginate = callPackage ../development/python-modules/flask-paginate { };

buku: 3.7 -> 3.8 #45033

buku: 3.7 -> 3.8 #45033

Conversation

infinisil commented Aug 14, 2018

Motivation for this change

Things done

infinisil Aug 14, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Aug 14, 2018

GrahamcOfBorg commented Aug 14, 2018

Mic92 Aug 15, 2018

Choose a reason for hiding this comment

infinisil Aug 15, 2018

Choose a reason for hiding this comment

infinisil Aug 15, 2018

Choose a reason for hiding this comment

Mic92 Aug 16, 2018 • edited

Choose a reason for hiding this comment

infinisil commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

GrahamcOfBorg commented Aug 17, 2018

infinisil commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

infinisil Aug 19, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

Mic92 Aug 16, 2018 •

edited