Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-ci: f7ab8c -> v0.1.0.0 #45035

Closed
wants to merge 1 commit into from
Closed

haskell-ci: f7ab8c -> v0.1.0.0 #45035

wants to merge 1 commit into from

Conversation

langston-barrett
Copy link
Contributor

Motivation for this change

Update to first numbered version, released 16 days ago

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@mpickering
Copy link
Contributor

I think this is now a normal hackage package so that the automatically generated version should be used rather than this manually maintained script.

https://hackage.haskell.org/package/haskell-ci

@langston-barrett
Copy link
Contributor Author

Is there anything that needs to be done, or can we just wait for the next update of the Hackage package set?

@mpickering
Copy link
Contributor

It is already in the package set. haskellPackages.haskell-ci.

@langston-barrett
Copy link
Contributor Author

I'll change this PR to remove this expression. Thanks for the pointer!

@mpickering
Copy link
Contributor

Any updates with this?

@langston-barrett
Copy link
Contributor Author

Not yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@langston-barrett @mpickering @GrahamcOfBorg