Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Entity AI #741

Merged
merged 13 commits into from Oct 5, 2018
Merged

Document Entity AI #741

merged 13 commits into from Oct 5, 2018

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Aug 14, 2018 •
edited

Fixes #377.

  • Explain Agents
  • Explain Goals
  • Explain Tasks
    • Example change Goal using existing Tasks
    • Example implement your own task
  • Explain Events

@ST-DDT ST-DDT added input wanted We would like to hear your opinion low priority Small issues like typos that don't have much of an impact labels Aug 14, 2018
@Spongy
Copy link

Spongy commented Aug 14, 2018 •
edited

A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/e530314/.

Here are some links to the pages that were modified:

Since the preview frequently changes, please link to this comment, not to the direct url to the preview.

@ST-DDT ST-DDT changed the title [WIP] Document Entity AI Document Entity AI Aug 18, 2018
@ST-DDT
Copy link
Member Author

ST-DDT commented Aug 18, 2018

Ready for review.

@Inscrutable Inscrutable added this to the v7.X milestone Aug 24, 2018
@ST-DDT ST-DDT added the needs review The submission is ready and needs to be reviewed label Aug 30, 2018
liach
liach approved these changes Aug 30, 2018
View reviewed changes
Copy link

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways, that other generic thing is subject to change in API 8. I believe the generic type needs to be refined.

Inscrutable
Inscrutable reviewed Sep 1, 2018
View reviewed changes
Copy link
Member

@Inscrutable Inscrutable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending a more articulate review of the code portions, I have oppressed the wording with more commas and stuff.

source/plugin/entities/ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/ai.rst Show resolved Hide resolved
source/plugin/entities/ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/custom-ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/custom-ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/custom-ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/custom-ai.rst Outdated Show resolved Hide resolved
source/plugin/entities/custom-ai.rst Outdated Show resolved Hide resolved
liach
liach reviewed Sep 1, 2018
View reviewed changes
source/plugin/entities/ai.rst Outdated Show resolved Hide resolved
liach
liach reviewed Sep 1, 2018
View reviewed changes
source/plugin/entities/ai.rst Outdated Show resolved Hide resolved
gabizou
gabizou approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@gabizou gabizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. No complaints.

@Zidane
Copy link
Member

Zidane commented Oct 4, 2018

Agreed with @gabizou

@liach
Copy link

liach commented Oct 4, 2018

Let's gladly accept this.

@Inscrutable Inscrutable removed input wanted We would like to hear your opinion needs review The submission is ready and needs to be reviewed labels Oct 5, 2018
@Inscrutable Inscrutable merged commit 44e17aa into stable Oct 5, 2018
@liach
Copy link

liach commented Oct 6, 2018

Uh, after translating, I found a few minor issues. They are fine

@ST-DDT ST-DDT deleted the feature/entity-ai branch November 5, 2018 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inscrutable Inscrutable Inscrutable left review comments

@liach liach liach approved these changes

@gabizou gabizou gabizou approved these changes

@Zidane Zidane Awaiting requested review from Zidane

Assignees
No one assigned
Labels
low priority Small issues like typos that don't have much of an impact
Projects
None yet
Milestone
v7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ST-DDT @Spongy @Zidane @liach @Inscrutable @gabizou