Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vscode from 1.15.1 -> 1.26.0 #45029

Merged
merged 1 commit into from Aug 14, 2018
Merged

Update vscode from 1.15.1 -> 1.26.0 #45029

merged 1 commit into from Aug 14, 2018

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Aug 14, 2018

Motivation for this change

Upgrade to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@gebner
Copy link
Member

gebner commented Aug 14, 2018 •
edited

The commit message should be vscode: 1.25.1 -> 1.26.0

@rawkode
Copy link
Member Author

rawkode commented Aug 14, 2018

@gebner Fixed

@gebner
Copy link
Member

gebner commented Aug 14, 2018

@GrahamcOfBorg build vscode

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: vscode

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: vscode

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@gebner gebner merged commit 9c40183 into NixOS:master Aug 14, 2018
@gebner
Copy link
Member

gebner commented Aug 14, 2018

Forgot that vscode is unfree...

@rawkode rawkode deleted the feature/upgrade-vscode branch August 15, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rawkode @gebner @GrahamcOfBorg