Add support for user-extensible shellHook to haskell.lib.buildStackProject #44568
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haskell.lib.buildStackProject
is overridding shell hook and doesn't appenduser-specified shellHook to it, resulting in user's shellHook
never executing.
I believe
shellHook
should be appended afteraddStackArgsHook
has been executed, but I can see a case for being executed beforehand too so if that is preferred approach let me know and I'll fix it.Motivation for this change
Ability to add shellHook commands to stack nix environments.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)Testing:
Result: