Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stage-1: Remove last reference of now-removed stdenv.isCross #44576

Merged
merged 1 commit into from Aug 7, 2018
Merged

stage-1: Remove last reference of now-removed stdenv.isCross #44576

merged 1 commit into from Aug 7, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

#44367 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 merged commit 643e8d5 into NixOS:staging Aug 7, 2018
@KiaraGrouwstra KiaraGrouwstra mentioned this pull request Aug 26, 2018
Closed
@KiaraGrouwstra
Copy link
Contributor

To those who didn't get this fix yet searching for the error it throws:

error: attribute 'isCross' missing, at /nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/system/boot/stage-1.nix:182:27

@Ericson2314 Ericson2314 deleted the last-isCross branch August 26, 2018 20:22
@Ericson2314
Copy link
Member Author

Thanks for helping make this more discoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @KiaraGrouwstra