rclone-browser: init at 1.2 #44589
Merged
rclone-browser: init at 1.2 #44589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
reviewed
Aug 7, 2018
pkgs/top-level/all-packages.nix
Outdated
| @@ -18129,7 +18129,8 @@ with pkgs; | |||
| }; | |||
|
|
|||
| rclone = callPackage ../applications/networking/sync/rclone { }; | |||
|
|
|||
| rclone-browser = callPackage ../applications/networking/sync/rclone/browser.nix { }; | |||
There was a problem hiding this comment.
one empty line inbetween please
dotlambda
reviewed
Aug 7, 2018
| description = "Graphical Frontend to Rclone written in Qt"; | ||
| homepage = https://github.com/mmozeiko/RcloneBrowser; | ||
| license = licenses.unlicense; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
Fails on Darwin:
CMake Error at CMakeLists.txt:14 (find_package):
By not providing "FindQt5MacExtras.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"Qt5MacExtras", but CMake did not find one.
Could not find a package configuration file provided by "Qt5MacExtras" with
any of the following names:
Qt5MacExtrasConfig.cmake
qt5macextras-config.cmake
Add the installation prefix of "Qt5MacExtras" to CMAKE_PREFIX_PATH or set
"Qt5MacExtras_DIR" to a directory containing one of the above files. If
"Qt5MacExtras" provides a separate development package or SDK, be sure it
has been installed.
-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-rclone-browser-1.2.drv-0/source/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/bbcpjpzqhnnalljyafvb9zfbdzzxlj7q-rclone-browser-1.2.drv' failed with exit code 1
error: build of '/nix/store/bbcpjpzqhnnalljyafvb9zfbdzzxlj7q-rclone-browser-1.2.drv' failed
dotlambda
reviewed
Aug 7, 2018
| sha256 = "1ldradd5c606mfkh46y4mhcvf9kbjhamw0gahksp9w43h5dh3ir7"; | ||
| }; | ||
| buildInputs = [ qt5.qtbase cmake ]; | ||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
This could also use some whitespace.
dotlambda
reviewed
Aug 7, 2018
| src = fetchFromGitHub { | ||
| owner = "mmozeiko"; | ||
| repo = "RcloneBrowser"; | ||
| rev = "${version}"; |
dotlambda
reviewed
Aug 7, 2018
| @@ -0,0 +1,20 @@ | |||
| { stdenv, fetchFromGitHub , rclone, qt5,cmake }: | |||
ryantm
requested changes
Sep 11, 2018
|
I would rather close the PR, since it isn't going to work as expected. |
What isn't working? It's working fine for me. |
dotlambda
reviewed
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)