Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cli-helpers: init at 1.0.2 #44578

Closed
wants to merge 1 commit into from
Closed

pythonPackages.cli-helpers: init at 1.0.2 #44578

wants to merge 1 commit into from

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 6, 2018 •
edited

Motivation for this change

cli-helpers is a required module of mycli v1.17.0. See #44571

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit requested a review from FRidh as a code owner August 6, 2018 22:50
@xeji
Copy link
Contributor

xeji commented Aug 6, 2018

@GrahamcOfBorg build python36Packages.cli-helpers python27Packages.cli-helpers

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.cli-helpers, python27Packages.cli-helpers

Partial log (click to expand)

Ran 0 tests in 0.000s

OK

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/2zff03hqmxi1va21w5zbpn32wjkk65pv-python3.6-cli_helpers-1.0.2
/nix/store/p0smcg5klqq1kxhlc1ysxfwni82k5vkc-python2.7-cli_helpers-1.0.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.cli-helpers, python27Packages.cli-helpers

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'cli_helpers.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.001s

OK
/nix/store/wz7ky5g0x4i7w3b5nwh7vj0d2p1jwjxj-python3.6-cli_helpers-1.0.2
/nix/store/4fq6cyqv3x3p44rq5ili3mgsnywfbiwp-python2.7-cli_helpers-1.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.cli-helpers, python27Packages.cli-helpers

Partial log (click to expand)

reading manifest template 'MANIFEST.in'
writing manifest file 'cli_helpers.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/s60y6x15c2j6azb89bbh14x5hgjmn5sr-python3.6-cli_helpers-1.0.2
/nix/store/vy0c0iaz6bhqhzmwbqw5k1spnipxn65a-python2.7-cli_helpers-1.0.2

@xeji
Copy link
Contributor

xeji commented Aug 6, 2018

Ran 0 tests in 0.000s

Are there really no tests?

@kalbasit
Copy link
Member Author

kalbasit commented Aug 6, 2018

@xeji looking upstream there is, https://github.com/dbcli/cli_helpers/tree/master/tests I also checked the package at Pypi and the tests are also included.

@kalbasit
Copy link
Member Author

kalbasit commented Aug 6, 2018

@xeji I'm not very familiar with buildPythonPackage, how does it determine how to run the tests?

@kalbasit kalbasit mentioned this pull request Aug 7, 2018
Merged
9 tasks
@kalbasit
Copy link
Member Author

kalbasit commented Aug 7, 2018

@xeji @dotlambda so I'd like to drop-shell in the doCheck command so I can play around and try to debug why the tests are not running, how can I do that?

@dotlambda
Copy link
Member

included in #44571

@dotlambda dotlambda closed this Aug 7, 2018
@kalbasit kalbasit deleted the nixpkgs_add-cli-helpers branch August 7, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kalbasit @xeji @GrahamcOfBorg @dotlambda