Workaround for issue #44254 (Steam cannot connect to friends network) #44602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for issue NixOS#44254 (Steam cannot connect to friends network)
puffnfresh
approved these changes
Sep 16, 2018
Ekleog
reviewed
Sep 23, 2018
pkgs/games/steam/chrootenv.nix
Outdated
| # Workaround for issue #44254 (Steam cannot connect to friends network) | ||
| # https://github.com/NixOS/nixpkgs/issues/44254 | ||
| test -z ''${TZ+x} && | ||
| new_TZ="$(readlink -f /etc/localtime | grep -o '(?<=/zoneinfo/).*$' -P)" && |
There was a problem hiding this comment.
The -P argument to grep could go just after grep like grep -P -o '...', that would likely make reading the code easier (as one would know that they are reading a PCRE regex before actually reading it)
There was a problem hiding this comment.
Thanks for the advice. I'll do that.
Makes reading the code easier, as one would know that they are reading a PCRE regex before actually reading it.
Ekleog
approved these changes
Sep 23, 2018
grahamc
reviewed
Sep 23, 2018
|
If somebody needs this to be backported, feel free to open another PR for it (with a cherry-pick -xe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When /etc/localtime is a valid symlink but doesn't point directly to a zoneinfo file, Steam has trouble connecting to friends network. I've reported this upstream, maybe they'll fix it. But for now, there's this workaround.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)