Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tensorflow 1.9 #44599

Merged
merged 3 commits into from Aug 7, 2018
Merged

Update to tensorflow 1.9 #44599

merged 3 commits into from Aug 7, 2018

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Aug 7, 2018

Motivation for this change

Upstream update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jyp jyp requested a review from FRidh as a code owner August 7, 2018 09:53
@jyp
Copy link
Contributor Author

jyp commented Aug 7, 2018

extends #42783 by @dotlambda

@dotlambda
Copy link
Member

There's a merge conflict.

@dotlambda dotlambda mentioned this pull request Aug 7, 2018
Closed
9 tasks
@jyp
Copy link
Contributor Author

jyp commented Aug 7, 2018

@dotlambda Oops, I had pushed the merge to the wrong branch. Fixed now.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.tensorflow python3.pkgs.tensorflow python2.pkgs.tensorflow-tensorboard python.pkgs.tensorflow-tensorboard

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.tensorflow, python3.pkgs.tensorflow, python2.pkgs.tensorflow-tensorboard, python.pkgs.tensorflow-tensorboard

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
configuring
building
installing
/build/dist /build
tensorflow-1.9.0-cp27-none-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/ysqamjsq794zylymwpi0pbrkjgwvzmlw-python2.7-tensorflow-1.9.0.drv' failed with exit code 1
tensorflow-1.9.0-cp36-cp36m-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/85x91zcp99ij0l3q13pzvwpva0rlj4id-python3.6-tensorflow-1.9.0.drv' failed with exit code 1
error: build of '/nix/store/85x91zcp99ij0l3q13pzvwpva0rlj4id-python3.6-tensorflow-1.9.0.drv', '/nix/store/ysqamjsq794zylymwpi0pbrkjgwvzmlw-python2.7-tensorflow-1.9.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.tensorflow, python3.pkgs.tensorflow, python2.pkgs.tensorflow-tensorboard, python.pkgs.tensorflow-tensorboard

Partial log (click to expand)

checking for references to /build in /nix/store/riv635850ix9wy8rkc2x3vfkv3r1pc4n-python3.6-tensorflow-1.9.0...
wrapping `/nix/store/riv635850ix9wy8rkc2x3vfkv3r1pc4n-python3.6-tensorflow-1.9.0/bin/tflite_convert'...
wrapping `/nix/store/riv635850ix9wy8rkc2x3vfkv3r1pc4n-python3.6-tensorflow-1.9.0/bin/saved_model_cli'...
wrapping `/nix/store/riv635850ix9wy8rkc2x3vfkv3r1pc4n-python3.6-tensorflow-1.9.0/bin/toco_from_protos'...
wrapping `/nix/store/riv635850ix9wy8rkc2x3vfkv3r1pc4n-python3.6-tensorflow-1.9.0/bin/freeze_graph'...
wrapping `/nix/store/riv635850ix9wy8rkc2x3vfkv3r1pc4n-python3.6-tensorflow-1.9.0/bin/toco'...
/nix/store/2x04fpj223vq4hax91ic90p49245hg0s-python2.7-tensorflow-1.9.0
/nix/store/riv635850ix9wy8rkc2x3vfkv3r1pc4n-python3.6-tensorflow-1.9.0
/nix/store/kz72n8mlimhddw6qzfgkx7l58lx67ssj-python2.7-tensorflow-tensorboard-1.9.0
/nix/store/kz72n8mlimhddw6qzfgkx7l58lx67ssj-python2.7-tensorflow-tensorboard-1.9.0

@dotlambda
Copy link
Member

We should probably update meta.platforms.

@dotlambda dotlambda merged commit 80bf2e3 into NixOS:master Aug 7, 2018
@dotlambda dotlambda mentioned this pull request Aug 7, 2018
Closed
@baracoder baracoder mentioned this pull request Sep 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jyp @dotlambda @GrahamcOfBorg