repl: don't add trailing spaces to history lines #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it's better to do |
|
I tried something like that first, but then I examined several other REPLs (Python, Elixir, zsh, bash), which all preserve user-entered whitespace. The preservation seemed to feel less surprising (e.g. when blindly pressing Backspace some number of times after Up), so I left it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2314.
I tested this manually and confirmed that a trailing space is no longer present when hitting
Upto get a previous line, and that multi-line input still works, and that ctrl-c and ctrl-d still work.Sidenote: I had to revert 7de3e00 to build nix with nixpkgs master because the aws-sdk-cpp patch failed to apply.