Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reason: 3.0.4 -> 3.3.2 #44593

Merged
merged 1 commit into from Aug 7, 2018
Merged

reason: 3.0.4 -> 3.3.2 #44593

merged 1 commit into from Aug 7, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Aug 7, 2018

https://github.com/facebook/reason/blob/master/HISTORY.md#332

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reason

Partial log (click to expand)

shrinking /nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2/bin/refmt
shrinking /nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2/bin/refmttype
shrinking /nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2/bin/reactjs_jsx_ppx_v2
shrinking /nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2/bin/testOprint
shrinking /nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2/bin/ocamlmerlin-reason
patching script interpreter paths in /nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2
/nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2/bin/rtop_init.ml: interpreter directive changed from "/usr/bin/env ocaml" to "/nix/store/iw53m92hfyxm9wxw5vf7kghv2j8sg67b-ocaml-4.05.0/bin/ocaml"
/nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2/bin/.rtop-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/dkh7l9a4sx7zqh8riqbj3z21sz25p8xy-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2...
/nix/store/l8h2c680hz64n3q60pqd4c38n842a4f0-ocaml-reason-3.3.2

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: reason

Partial log (click to expand)

make[3]: *** [../OCamlMakefile:792: byte-code-library] Error 2
make[3]: Leaving directory '/build/opam-1.2.2/src_ext'
make[2]: *** [../OCamlMakefile:1227: subproj_extlib] Error 2
make[2]: Leaving directory '/build/opam-1.2.2/src_ext'
make[1]: *** [Makefile:39: build] Error 2
make[1]: Leaving directory '/build/opam-1.2.2/src_ext'
make: *** [Makefile:29: lib-ext] Error 2
builder for '/nix/store/95i4rfv9a05pr1867apgqx9jzvljls2d-opam-1.2.2.drv' failed with exit code 2
cannot build derivation '/nix/store/b8wr53yiqmrswf6y51bvgxr40nv4p21f-ocaml-reason-3.3.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/b8wr53yiqmrswf6y51bvgxr40nv4p21f-ocaml-reason-3.3.2.drv' failed

xeji
xeji reviewed Aug 7, 2018
View reviewed changes
pkgs/development/compilers/reason/default.nix

src = fetchFromGitHub {
owner = "facebook";
repo = "reason";
rev = version;
sha256 = "15qhx85him5rr4j0ygj3jh3qv9ijrn82ibr9scbn0qrnn43kj047";
rev = "68a4124c772ee25c4729b005c8643851b1e17b92";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a yet unreleased rev of upstream master. Shouldn't we wait for official release of 3.3.2?

Copy link
Member Author

@dywedir dywedir Aug 7, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They had some troubles with release scripts, so there are no github releases/tags since then :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like they just update the changelog to "release" stuff.
Weird but if that's the way they want to do it, fine with me.

@xeji
Copy link
Contributor

xeji commented Aug 7, 2018 •
edited

opam build has failed on aarch64 for a while, so let's ignore that for now.

@xeji xeji merged commit 23fd014 into NixOS:master Aug 7, 2018
@dywedir dywedir deleted the reason branch August 7, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @GrahamcOfBorg @xeji