Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set initialHashedPassword in installation-device.nix #44570

Merged
merged 1 commit into from Aug 7, 2018
Merged

set initialHashedPassword in installation-device.nix #44570

merged 1 commit into from Aug 7, 2018

Conversation

bobvanderlinden
Copy link
Member

Motivation for this change

There were a few FIXMEs in some of the installation files saying:

# FIXME: this probably should be in installation-device.nix
users.users.root.initialHashedPassword = "";

It indeed seemed sensible to move users.users.root.initialHashedPassword to installation-device.nix, so I moved it. I ran one of the installation tests, but have not run them all.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

infinisil
infinisil approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobvanderlinden
Copy link
Member Author

It would be helpful to let @GrahamcOfBorg run the installation tests. Not sure how to instruct it to do so.

@infinisil
Copy link
Member

Pretty sure this change wouldn't change any derivations, but I guess it can't hurt to do one

@GrahamcOfBorg test installer.simple

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.installer.simple

Partial log (click to expand)

while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/nixos/release.nix:30:25, called from /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/lib/attrsets.nix:200:54:
while evaluating 'hydraJob' at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/lib/customisation.nix:157:14, called from /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/nixos/release.nix:30:28:
while evaluating the attribute 'drvPath' at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/lib/customisation.nix:174:13:
while evaluating the attribute 'drvPath' at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/lib/customisation.nix:141:13:
while evaluating the attribute 'buildCommand' of the derivation 'vm-test-run-installer-simple' at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/pkgs/stdenv/generic/make-derivation.nix:175:11:
while evaluating the attribute 'testScript' of the derivation 'nixos-test-driver-installer-simple' at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/pkgs/stdenv/generic/make-derivation.nix:175:11:
while evaluating 'isFunction' at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/lib/trivial.nix:221:16, called from /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/nixos/lib/testing.nix:104:12:
while evaluating 'testScriptFun' at /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/nixos/tests/installer.nix:65:19, called from /var/lib/gc-of-borg/nix-test-rs-6/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-6/nixos/tests/installer.nix:264:20:
Non-EFI boot methods are only supported on i686 / x86_64

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: tests.installer.simple

Partial log (click to expand)

cannot build derivation '/nix/store/lckbzb7a0cwf2yqfs0b03y9gqak8f46a-etc.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nqrwfgkbc597r3w8xdl0cpcxg35wzjfr-stage-1-init.sh.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x3fwczn9l8hbgpyzvr0876n3m59n8xyq-initrd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wi8l1nkhmhp9ppd3n9lb16hd3d23aidc-nixos-system-machine-18.09.git.dd14c32.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/xsjcaxi72s1yzfvv4x1780w1zasxwdm8-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4jgxbwn2fjw3z3awjma7431dh04h8fbx-run-nixos-vm.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/1smniyyb8mvq622l0sglf866js04jzkx-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wswyg2dzgjyh7wcsgv9lyqbfcvxqrnkw-nixos-test-driver-installer-simple.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ghp8qgph4cbriq5l3cm98d5wwbzjs7n4-vm-test-run-installer-simple.drv': 1 dependencies couldn't be built
error: build of '/nix/store/ghp8qgph4cbriq5l3cm98d5wwbzjs7n4-vm-test-run-installer-simple.drv' failed

@bobvanderlinden
Copy link
Member Author

Hmm, timed out. Another try? @GrahamcOfBorg test installer.simple

@infinisil
Copy link
Member

Eh this is fine, nothing can break from this. It will also just timeout again.

And only trusted users can currently invoke the bot to build stuff.

@infinisil infinisil merged commit e1da32d into NixOS:master Aug 7, 2018
@bobvanderlinden
Copy link
Member Author

Good to know. Thanks for the merge!

@bobvanderlinden bobvanderlinden deleted the empty-password-installation-device branch August 7, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @infinisil @GrahamcOfBorg