Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gwyddion, ripser: fix derivation name #44577

Merged
merged 1 commit into from Aug 6, 2018
Merged

gwyddion, ripser: fix derivation name #44577

merged 1 commit into from Aug 6, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

the version attribute was pulled from stdenv.lib and was wrong as a result. Furthermore, since stdenv.lib.version changes with each commit, this triggers a rebuild of these derivations on each commit (and always with nox-review).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 6, 2018

@GrahamcOfBorg build gwyddion ripser

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gwyddion, ripser

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: gwyddion, ripser

Partial log (click to expand)

building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8j5h7vrva63jzkv4v7j55fyp15izcvnz-ripser-1.0
shrinking /nix/store/8j5h7vrva63jzkv4v7j55fyp15izcvnz-ripser-1.0/bin/ripser
strip is /nix/store/1hi76hr87bd1y1q1qjk0lv8nmcjip1c8-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8j5h7vrva63jzkv4v7j55fyp15izcvnz-ripser-1.0/bin
patching script interpreter paths in /nix/store/8j5h7vrva63jzkv4v7j55fyp15izcvnz-ripser-1.0
checking for references to /build in /nix/store/8j5h7vrva63jzkv4v7j55fyp15izcvnz-ripser-1.0...
error: build of '/nix/store/v33g415cxy0nz6z1na0348wlklj9nxag-gwyddion-2.48.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gwyddion, ripser

Partial log (click to expand)

shrinking /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48/lib/libgwyprocess2.so.0.31.0
shrinking /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48/lib/libgwyddion2.so.0.22.1
gzipping man pages under /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48/share/man/
strip is /nix/store/zrs21zqcchgyabjf4xfimncdq16njizc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48/lib  /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48/libexec  /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48/bin
patching script interpreter paths in /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48
/nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48/libexec/gwyddion/plugins/process/yellow.sh: interpreter directive changed from "/bin/sh" to "/nix/store/6vqgi9d49smsbr2qxra52yhipg0yxf9f-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48...
/nix/store/sflix0lsw60dfgz8q9n2w9akj2bp7bfz-gwyddion-2.48
/nix/store/w0ywgidn17qhd1kc3x4z9fvl893kpfqm-ripser-1.0

@xeji
Copy link
Contributor

xeji commented Aug 6, 2018

Let's ignore the timeout, happens a lot these days.

@xeji xeji merged commit 0ca40a5 into NixOS:master Aug 6, 2018
@symphorien symphorien deleted the fix-versions branch March 21, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @xeji @GrahamcOfBorg