Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rPackages.haven: fix installation #43408

Merged
merged 1 commit into from Jul 12, 2018
Merged

rPackages.haven: fix installation #43408

merged 1 commit into from Jul 12, 2018

Conversation

iimog
Copy link
Member

@iimog iimog commented Jul 12, 2018

Motivation for this change

Installation of rPackages.haven fails using the current master branch of NixOS/nixpkgs (18.03-beta-14880-ge65bdb91997). This causes installation of rPackages.tidyverse to fail as well.
The cause of the error is the missing buildInput pkgs.zlib.dev.

Steps to reproduce
nix-build -E 'with import <nixpkgs> {}; rWrapper.override { packages = [rPackages.haven]; }'

Resulting in (partial output):

...

readstat/spss/readstat_zsav_write.c:3:10: fatal error: zlib.h: No such file or directory
 #include <zlib.h>
          ^~~~~~~~
compilation terminated.
make: *** [/nix/store/38s6jybgbpxprys4pbgyc83f1zkfl8sj-R-3.5.1/lib/R/etc/Makeconf:159: readstat/spss/readstat_zsav_write.o] Error 1
ERROR: compilation failed for package 'haven'
* removing '/nix/store/8gb8wdk33jsjj78xlcyw6cj1yp7dhj51-r-haven-1.1.2/library/haven'
builder for '/nix/store/4zhk033hcfyih4kk1hiv9fr96f5a0ahy-r-haven-1.1.2.drv' failed with exit code 1
cannot build derivation '/nix/store/viz2ikwnqc4p3vj59f1pjgadiwmal0ql-R-3.5.1-wrapper.drv': 1 dependencies couldn't be built
error: build of '/nix/store/viz2ikwnqc4p3vj59f1pjgadiwmal0ql-R-3.5.1-wrapper.drv' failed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@iimog iimog requested a review from peti as a code owner July 12, 2018 09:34
@peti
Copy link
Member

peti commented Jul 12, 2018

@GrahamcOfBorg build rPackages.haven

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rPackages.haven

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rPackages.haven

Partial log (click to expand)

*** installing help indices
*** copying figures
** building package indices
** installing vignettes
** testing if installed package can be loaded
* DONE (haven)
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/x7vijyknw29myk1hbjmy6fb71807a3f5-r-haven-1.1.2
/nix/store/x7vijyknw29myk1hbjmy6fb71807a3f5-r-haven-1.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rPackages.haven

Partial log (click to expand)

** installing vignettes
** testing if installed package can be loaded
* DONE (haven)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2
shrinking /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2/library/haven/libs/haven.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2
checking for references to /build in /nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2...
/nix/store/ssrq8q46l11qw7fz48s3q985dfay2jdv-r-haven-1.1.2

@peti peti merged commit b1e298f into NixOS:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iimog @peti @GrahamcOfBorg