Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: c2de2ff385a7
Choose a base ref
...
head repository: NixOS/nix
compare: 1b34b69b4510
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 12, 2018

  1. nix-prefetch-url: Download file in constant memory 

    Before:

  $ command time nix-prefetch-url https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-4.17.6.tar.xz
  1.19user 1.02system 0:41.96elapsed 5%CPU (0avgtext+0avgdata 182720maxresident)k

After:

  1.38user 1.05system 0:39.73elapsed 6%CPU (0avgtext+0avgdata 16204maxresident)k

Note however that addToStore() can still take a lot of memory
(e.g. RemoteStore::addToStore() is constant space, but
LocalStore::addToStore() isn't; that's fixed by
edolstra@c94b4fc
though).

Fixes #1400.
    @edolstra
    edolstra committed Jul 12, 2018
    Copy the full SHA
    1b34b69 View commit details
    Browse the repository at this point in the history