Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: "backport" another patch, fix crash w/Go and Octave #43423

Merged
merged 1 commit into from Jul 12, 2018
Merged

openblas: "backport" another patch, fix crash w/Go and Octave #43423

merged 1 commit into from Jul 12, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 12, 2018

Also fixes numpy crashing during tests w/musl.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
openblas: backport another patch, fix crash w/Go and Octave
1b3d8ee 
Also fixes numpy crashing during tests w/musl.
@dtzWill
Copy link
Member Author

dtzWill commented Jul 12, 2018

@GrahamcOfBorg build pkgsMusl.pythonPackages.numpy

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pkgsMusl.pythonPackages.numpy

Partial log (click to expand)

Cannot nix-instantiate `pkgsMusl.pythonPackages.numpy' because:
�[31;1merror:�[0m Musl libc only supports Linux systems.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 12, 2018

May be of interest to those involved with #43234.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pkgsMusl.pythonPackages.numpy

Partial log (click to expand)

cannot build derivation '/nix/store/r9pfqkwz0n9vsikyl2gpsf8fw2ziz4if-hook.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/06pnr823718cwpdvi3nqxdv765jiyzlf-python2.7-bootstrapped-pip-10.0.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/n4z8a7v5yj4p99630c3v8j056cx0351k-source.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/9q9nlrxx7b27kkqpz8z6kbj335m621a8-gfortran-wrapper-7.3.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/6x9sr33b1w2fkq0qnl0r80z2fdfj6gcs-python2.7-setuptools-39.2.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/gzrihmnznf5k72ba0xq0x2ym6153iafn-openblas-0.3.1.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/dmrsrcb8ikdpmm5vlpkn1ggvyz3xvbng-python2.7-coverage-4.5.1.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/g1idkh2fqxcbyiq8f91ii6asidf3jbf7-python2.7-nose-1.3.7.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/k10bbh25g6d6ljk9cc0y3x7n6bjly3jk-python2.7-numpy-1.14.5.drv': 11 dependencies couldn't be built
error: build of '/nix/store/k10bbh25g6d6ljk9cc0y3x7n6bjly3jk-python2.7-numpy-1.14.5.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openblas

Partial log (click to expand)

Install OK!
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y34hp5sbkhfm9p1hs4s9mmars2a7wzcs-openblas-0.3.1
shrinking /nix/store/y34hp5sbkhfm9p1hs4s9mmars2a7wzcs-openblas-0.3.1/lib/libopenblasp-r0.3.1.so
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y34hp5sbkhfm9p1hs4s9mmars2a7wzcs-openblas-0.3.1/lib  /nix/store/y34hp5sbkhfm9p1hs4s9mmars2a7wzcs-openblas-0.3.1/bin
patching script interpreter paths in /nix/store/y34hp5sbkhfm9p1hs4s9mmars2a7wzcs-openblas-0.3.1
checking for references to /build in /nix/store/y34hp5sbkhfm9p1hs4s9mmars2a7wzcs-openblas-0.3.1...
/nix/store/y34hp5sbkhfm9p1hs4s9mmars2a7wzcs-openblas-0.3.1

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: openblas

Partial log (click to expand)

cannot build derivation '/nix/store/wcjn6hpd3c265zzhh7zmps93xg1kvviy-gfortran-7.3.0.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/hd3zkqa9zry54ghv31nv658z91wx469y-libssh2-1.8.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/bfcryivplxsdgi7z0ngrslca0s76562g-nghttp2-1.32.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/fnzqbv0gcj1jxylq0i4zs4crfymrpih5-curl-7.60.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/5d25d4jbj6lckj4g777gjfm4vxhxx3rm-gfortran-wrapper-7.3.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/fg6c76l48y9wyyg166k4ncjix1drwxd6-5f2a3c05cd0e3872be3c5686b9da6b627658eeb7.patch.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/3s35fccpcb67m3c0rvi0hrbkxf9xcqid-a49203b48c4a3d6f86413fc8c4b1fbfaa1946463.patch.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/yzj0k8wzyg4hw6i057kb9kf3iv2d68zr-source.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/1lclnrvrcndbh3k4s67mfdxi1cv4mrj1-openblas-0.3.1.drv': 9 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/1lclnrvrcndbh3k4s67mfdxi1cv4mrj1-openblas-0.3.1.drv' failed

@dtzWill dtzWill merged commit 4f8ec6f into NixOS:staging Jul 12, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pkgsMusl.pythonPackages.numpy

Partial log (click to expand)

----------------------------------------------------------------------
Ran 6810 tests in 291.210s

FAILED (KNOWNFAIL=20, SKIP=15, errors=1, failures=29)
NumPy version 1.14.5
NumPy relaxed strides checking option: True
NumPy is installed in /nix/store/bfj24d7ckgz0a23mp1zdw7m2blw4qyfy-python2.7-numpy-1.14.5/lib/python2.7/site-packages/numpy
Python version 2.7.15 (default, Apr 29 2018, 23:18:59) [GCC 7.3.0]
nose version 1.3.7
/build/numpy-1.14.5

@dtzWill
Copy link
Member Author

dtzWill commented Jul 12, 2018

Merging somewhat eagerly, since:

  • it's picked from upstream
  • IMO (from discussion upstream, mostly) it's low-risk and at worst unnecessarily increases the size of a table (no one seemed concerned)
  • we just patched openblas so let's try to catch that train before it entirely leaves the station.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: openblas

Partial log (click to expand)

cannot build derivation '/nix/store/k8znvcgspr19pc0nd31q1qlfl4gras9q-which-2.21.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3gb1aszvnsvnjms520j3311xqjphpkli-gmp-6.1.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/hs3w1lhzbwjffc1xijp20x7gb0idb8jl-libelf-0.8.13.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/zkq3qrv3v00q7cm2f4k15v4hxfflm4xc-isl-0.17.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/bfisws9cwca3360yxqkdzci9670phdxn-mpfr-4.0.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8v1v2j7kvbjcp2n2r2abv66albx6hfj1-libmpc-1.1.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/ihk4l7impvg8rdhyfn5nc9xvhz1d26y3-gfortran-7.3.0.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/dv0l3dvnv7l4fll3vgjh5x0nxhbx0l4a-gfortran-wrapper-7.3.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/jn9mghpmm7wvcasfhggsdhs453a4lzv5-openblas-0.3.1.drv': 5 dependencies couldn't be built
error: build of '/nix/store/jn9mghpmm7wvcasfhggsdhs453a4lzv5-openblas-0.3.1.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg