Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: d1dfcb8e5ae3
Choose a base ref
...
head repository: jruby/jruby
compare: 8de990b5b11d
Choose a head ref
  • 7 commits
  • 8 files changed
  • 1 contributor

Commits on Jul 12, 2018

  1. Local variable lookup before init may return null, guard this.

    @headius
    headius committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    75401aa View commit details
    Browse the repository at this point in the history

  2. Fix log message for indirect Java binding with block.

    @headius
    headius committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    c173c82 View commit details
    Browse the repository at this point in the history

  3. Enable direct binding for keyword args methods. 

    Ideally we need to slim down or eliminate the frobnicate logic,
since it's over complex and likely will limit the inlining
potential of these call sites.

See #5246.
    @headius
    headius committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    0a7419a View commit details
    Browse the repository at this point in the history

  4. Add method toString to indy binding log.

    @headius
    headius committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    f7667df View commit details
    Browse the repository at this point in the history

  5. Kill a couple more '19' methods from String.

    @headius
    headius committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    018bc06 View commit details
    Browse the repository at this point in the history

  6. Reorder these, since indy only directly binds the first defined.

    @headius
    headius committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    64a1a16 View commit details
    Browse the repository at this point in the history

  7. Additional indy binding log improvements. 

    * Match wording for directly bound jitted methods
* Use method location for printing out method's impl class
* Log when a native method failed to bind directly due to arity

See related work in #5246.
    @headius
    headius committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    8de990b View commit details
    Browse the repository at this point in the history