Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percona-xtrabackup: 2.4.9 -> 2.4.12 #43413

Merged
merged 2 commits into from Jul 15, 2018
Merged

percona-xtrabackup: 2.4.9 -> 2.4.12 #43413

merged 2 commits into from Jul 15, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jul 12, 2018 •
edited

Motivation for this change

Update version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 14, 2018

@GrahamcOfBorg build percona-xtrabackup

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: percona-xtrabackup

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: percona-xtrabackup

Partial log (click to expand)

shrinking /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12/bin/xbcloud
shrinking /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12/bin/xbcrypt
shrinking /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12/lib/plugin/keyring_file.so
shrinking /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12/lib/plugin/keyring_vault.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12/lib  /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12/bin
patching script interpreter paths in /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12
/nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12/bin/xbcloud_osenv: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12...
/nix/store/za1g5xa444wbssy6x4hy1hqdk2lp5a3g-percona-xtrabackup-2.4.12

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: percona-xtrabackup

Partial log (click to expand)

shrinking /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12/bin/xbcloud
shrinking /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12/bin/xbcrypt
shrinking /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12/bin/xbstream
shrinking /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12/bin/xtrabackup
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12/lib  /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12/bin
patching script interpreter paths in /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12
/nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12/bin/xbcloud_osenv: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12...
/nix/store/46a7n34p94a3y3rbvms63h45a50kaz5d-percona-xtrabackup-2.4.12

xeji
xeji reviewed Jul 14, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -4364,6 +4364,7 @@ with pkgs;
pepper = callPackage ../tools/admin/salt/pepper { };

percona-xtrabackup = callPackage ../tools/backup/percona-xtrabackup {
stdenv = overrideCC stdenv gcc5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to downgrade to gcc5? Fixing the build with gcc7 would be the preferred solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know how to fix an error when building with gcc7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I'll help you with that. Will push a fix here shortly.

@xeji
Copy link
Contributor

xeji commented Jul 15, 2018

This builds on my machine with gcc7 but I have not tested the resulting app.
@Izorkin, please test.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jul 15, 2018

@xeji thanks. Works.

@xeji
Copy link
Contributor

xeji commented Jul 15, 2018

@GrahamcOfBorg build percona-xtrabackup

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: percona-xtrabackup

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: percona-xtrabackup

Partial log (click to expand)

shrinking /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12/bin/xbcloud
shrinking /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12/bin/xbcrypt
shrinking /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12/lib/plugin/keyring_file.so
shrinking /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12/lib/plugin/keyring_vault.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12/lib  /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12/bin
patching script interpreter paths in /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12
/nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12/bin/xbcloud_osenv: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12...
/nix/store/h37s0xkmnmilgzi8k1rzgjs54chr2gr8-percona-xtrabackup-2.4.12

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: percona-xtrabackup

Partial log (click to expand)

shrinking /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12/bin/xbcloud
shrinking /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12/bin/xbcrypt
shrinking /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12/bin/xbstream
shrinking /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12/bin/xtrabackup
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12/lib  /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12/bin
patching script interpreter paths in /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12
/nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12/bin/xbcloud_osenv: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12...
/nix/store/wmvkpqkjfxv9xgcnh3x6g504i83a1chi-percona-xtrabackup-2.4.12

@xeji xeji merged commit 0c6df10 into NixOS:master Jul 15, 2018
@Izorkin Izorkin deleted the percona-xtrabackup branch July 15, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @FRidh @GrahamcOfBorg @xeji