Add ECR.render for rendering without setting up an IO #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method reduces boilerplate IO pattern if you just need to render a ECR file in a string.
RX14
approved these changes
Jul 12, 2018
|
This is definitely useful 👍 |
sdogruyol
approved these changes
Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro reduces boilerplate IO pattern if you just need to render a ECR file in a string to make it more user-friendly.
There is something to be said about using the same name as
ECR.embedjust without the argumentioname. However, I feel likeECR.renderbetter describes what it does. I'm not settled, though, so any suggestions are welcome.See kemalcr/kemal#467