Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-{unix-time,prettyprinter}: dontCheck on musl #43422

Merged
merged 1 commit into from Jul 12, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 12, 2018

These block many packages, with these fixed these now build:

  • cachix
  • dhall
  • stack

In fact, these paths were pushed to the "allvm" cachix
using a musl-based 'cachix'! :D

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from peti as a code owner July 12, 2018 16:08
@dtzWill dtzWill merged commit ee57cb3 into NixOS:master Jul 12, 2018
@dtzWill dtzWill deleted the experimental/ghc-musl-misc-fixes branch July 12, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants