-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FreeBSD/aarch64 #6373
base: master
Are you sure you want to change the base?
Conversation
Thanks! About LLVM errors, I'm afraid you'll have to dig to understand where they come from. Maybe we have an issue with Crystal+LLVM6 on AArch64 😢 About spec failures:
It would be interesting to see which specs also fail on x86_64-freebsd12. |
No 6 is either an issue with environment variables ( For debugging, just add the following expression before the failing spec line: pp ENV["TZ"]?, Crystal::System::Time.load_localtime |
No. 6 should be fixed by #6740. |
@myfreeweb This needs an update after #7282. Also would be great if you could revisit the previously found issues. |
Just a symlink to the amd64 folder, as there's no difference in libc API.
cc6e4a6
to
cff0fb7
Compare
Updated the symlink (the patch here). I don't have the time to work on spec failures, unfortunately. |
Does this still work on recent LLVM versions? |
Why wouldn't it? There's nothing llvm dependent here, this PR simply adds symlinks for platform libc bindings (because there's no difference to amd64). We do build the downstream package (currently 1.1.1 with llvm10 yes i know it's time to update) for aarch64 using the same symlinks. |
Yes, it's just a symlink to the amd64 folder. It Just Worked™.
Compiler binary for FreeBSD 12: https://unrelentingtech.s3.dualstack.eu-west-1.amazonaws.com/crystal/crystal-0.25.1-freebsd12.0-aarch64
Works great with LLVM 5.0.2. LLVM 6.0.1 results in assertion failures:
On amd64, these don't appear.
Also, some spec failures:
They don't look very aarch64 related. I never ran spec on amd64 though…